-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging to download:plugins
script
#13905
Add logging to download:plugins
script
#13905
Conversation
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
6f60c21
to
5b86871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggestion, see below.
} | ||
} catch (error) { | ||
this._searchError = error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: We should stringify this error somehow, as _searchError
is defined as a string. (while error
is any
and likely of class Error
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equivalent of what we had before would be err?.message || String(err),
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be preferable. We shouldn't just assign any
to string
if we don't know what's been thrown.
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
What it does
Adds logging to get more info on CI failures descibed in #13902
Contributed on behalf of STMicroelectronics
How to test
Rerun the CI scripts until they fail.
Follow-ups
Review checklist
Reminder for reviewers