Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python VS Code extension #3771

Closed
3 tasks done
akosyakov opened this issue Dec 6, 2018 · 15 comments
Closed
3 tasks done

Python VS Code extension #3771

akosyakov opened this issue Dec 6, 2018 · 15 comments
Assignees
Labels
plug-in system issues related to the plug-in system python issues related to the python language / extension vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Dec 6, 2018

I've tried to run VS Code extension for Python. It was installed sucessfully, but it does not seem to work.

Contributions are not localized:
screen shot 2018-12-06 at 16 55 26

No language highlighting and support:
screen shot 2018-12-06 at 16 55 32

Errors from the backend:
screen shot 2018-12-06 at 16 55 41

@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility python issues related to the python language / extension labels Dec 6, 2018
@benoitf
Copy link
Contributor

benoitf commented Dec 6, 2018

yes some LSP extensions are also providing debug stuff but debug stuff is not yet there (not even mocked)
but @tolusha is working on it

@akosyakov
Copy link
Member Author

akosyakov commented Dec 6, 2018

@benoitf ok

Also turned out that this extension does not include python language definition but relies on build-in VS Code extension (which is not on marketplace): https://github.com/Microsoft/vscode/tree/master/extensions/python

I will try to run them together when VS Code debug APIs are implemented.

@mannau
Copy link

mannau commented Dec 26, 2018

@akosyakov Any updates on this after the merge?

@akosyakov
Copy link
Member Author

@mannau i would try to give it a spin again

@akosyakov
Copy link
Member Author

#3815 is needed for it

@tsmaeder
Copy link
Contributor

It seems there already is a python grammar registered in the current python extension for theia. We could just migrate that to the "textmate-grammars" package.

@akosyakov
Copy link
Member Author

@tsmaeder sounds good for now, eventually we don't want to support our textmate-grammars but consume them from source (VS Code)

@tolusha
Copy link
Contributor

tolusha commented Mar 4, 2019

Now it is possible to use VS Code python extension [1]

screenshot from 2019-03-04 10-59-59
screenshot from 2019-03-04 10-59-26

[1] https://marketplace.visualstudio.com/items?itemName=ms-python.python

@tolusha
Copy link
Contributor

tolusha commented Mar 4, 2019

Still have some errors in console

root ERROR Warning: Encountered two children with the same key, `$(refresh~spin) Refreshing Python Interpretersnull1null`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
    in div

@tolusha
Copy link
Contributor

tolusha commented Mar 6, 2019

#4493

@tolusha tolusha closed this as completed Mar 7, 2019
@Leletir
Copy link

Leletir commented Apr 1, 2019

@tolusha How did you manage to install the python debugger ?

@tolusha
Copy link
Contributor

tolusha commented Apr 1, 2019

@Leletir
Copy link

Leletir commented Apr 1, 2019

I'm using it on VS Code, so you've build Theia from source and added the plugins folder with this extension on it, isn't it ?

@tolusha
Copy link
Contributor

tolusha commented Apr 1, 2019

correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system python issues related to the python language / extension vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

6 participants