Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align UX for tasks with VS Code #4212

Closed
akosyakov opened this issue Feb 1, 2019 · 1 comment
Closed

Align UX for tasks with VS Code #4212

akosyakov opened this issue Feb 1, 2019 · 1 comment
Assignees
@elaihau
Labels
epic epic issues consisting of multiple smaller issues tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Feb 1, 2019 •
edited
Loading

It should be possible to follow along https://code.visualstudio.com/Docs/editor/tasks docs with Theia.

Related #1096, #4211, #4216

cc @marcdumais-work @svenefftinge
@akosyakov akosyakov added epic epic issues consisting of multiple smaller issues tasks issues related to the task system vscode issues related to VSCode compatibility labels Feb 1, 2019
@kittaakos kittaakos mentioned this issue Feb 15, 2019
Closed
@akosyakov akosyakov mentioned this issue Apr 29, 2019
Closed
@elaihau elaihau mentioned this issue Jun 4, 2019
Merged
elaihau pushed a commit that referenced this issue Aug 6, 2019
prompt user to choose parser to parse task output
90a9848 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212
elaihau pushed a commit that referenced this issue Aug 7, 2019
prompt user to choose parser to parse task output
351ea1a 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212
@elaihau elaihau mentioned this issue Aug 7, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Aug 7, 2019
prompt user to choose parser to parse task output
9d86a05 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 7, 2019
prompt user to choose parser to parse task output
5e35d9a 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Sep 5, 2019
prompt user to choose parser to parse task output
71bee03 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Sep 6, 2019
prompt user to choose parser to parse task output
eb39df7 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Sep 6, 2019
prompt user to choose parser to parse task output
7c19815 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Sep 6, 2019
prompt user to choose parser to parse task output
a866f32 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Sep 6, 2019
@elaihau
prompt user to choose parser to parse task output
263349a 
- before a task runs, prompt the user to choose which parser to use to
parse the task output, and write user's choice into `tasks.json`
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau self-assigned this Oct 15, 2019
elaihau pushed a commit that referenced this issue Oct 15, 2019
support creating tasks.json from template
82eead1 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists. If not, display "Create tasks.json file from template". If tasks.json exists and empty, display "Open tasks.json file".
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau mentioned this issue Oct 15, 2019
Merged
2 tasks
elaihau pushed a commit that referenced this issue Oct 17, 2019
support creating tasks.json from template
d9404ae 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists:
  - "Create tasks.json file from template" is displayed if 1) there are no detected or configured tasks, and 2) tasks.json does not exist
  - "Open tasks.json file" is displayed, if 1) tasks.json exists, and 2) no detected or configured tasks are found, display "Open tasks.json file".
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Oct 19, 2019
support creating tasks.json from template
8bf6e59 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists:
  - "Create tasks.json file from template" is displayed if 1) there are no detected or configured tasks, and 2) tasks.json does not exist
  - "Open tasks.json file" is displayed, if 1) tasks.json exists, and 2) no detected or configured tasks are found.
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit to elaihau/theia that referenced this issue Oct 31, 2019
support creating tasks.json from template
83a038f 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists:
  - "Create tasks.json file from template" is displayed if 1) there are no detected or configured tasks, and 2) tasks.json does not exist
  - "Open tasks.json file" is displayed, if 1) tasks.json exists, and 2) no detected or configured tasks are found.
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of eclipse-theia#4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Nov 2, 2019
support creating tasks.json from template
fad9056 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists:
  - "Create tasks.json file from template" is displayed if 1) there are no detected or configured tasks, and 2) tasks.json does not exist
  - "Open tasks.json file" is displayed, if 1) tasks.json exists, and 2) no detected or configured tasks are found.
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Nov 6, 2019
@elaihau
support creating tasks.json from template
602f44d 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists:
  - "Create tasks.json file from template" is displayed if 1) there are no detected or configured tasks, and 2) tasks.json does not exist
  - "Open tasks.json file" is displayed, if 1) tasks.json exists, and 2) no detected or configured tasks are found.
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of #4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
support creating tasks.json from template
1d83e61 
- group the tasks by workspace folder in the quick open item list populated by "Terminal" -> "Configure Tasks..."
- when "Configure Tasks" is started, check if tasks.json exists:
  - "Create tasks.json file from template" is displayed if 1) there are no detected or configured tasks, and 2) tasks.json does not exist
  - "Open tasks.json file" is displayed, if 1) tasks.json exists, and 2) no detected or configured tasks are found.
- add VS Code Task templates to Theia. CQ created http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967
- part of eclipse-theia#4212

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@vince-fugnitto
Copy link
Member

Given that the related issues are completed, and the UX is aligned with VS Code expectations, I would mark the epic as closed.
If we have concrete use-cases we can open specific issues to address any gaps or improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
epic epic issues consisting of multiple smaller issues tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @elaihau @vince-fugnitto