Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks contributed by VS Code extensions don't work #4216

Closed
akosyakov opened this issue Feb 1, 2019 · 7 comments
Closed

tasks contributed by VS Code extensions don't work #4216

akosyakov opened this issue Feb 1, 2019 · 7 comments
Assignees
Labels
bug bugs found in the application plug-in system issues related to the plug-in system tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

They look bogus:
screen shot 2019-02-01 at 09 16 36

And cannot be executed:
screen shot 2019-02-01 at 09 16 59

You can reproduce it with grunt & gulp VS Code built-in extensions.

@akosyakov akosyakov added bug bugs found in the application tasks issues related to the task system plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Feb 1, 2019
@akosyakov akosyakov changed the title tasks contributed by VS Code extension does not work tasks contributed by VS Code extensions don't work Feb 1, 2019
@akosyakov
Copy link
Member Author

@elaihau What I do for now to try built-in VS Code extensions, for example for grunt:

  • clone and install this extension https://github.com/theia-ide/vscode-builtin-extensions somewhere
  • after that copy vscode-builtin-extensions/vscode/extensions/grunt to theia/plugins
  • then start Theia, grunt VS Code extension should be installed, check plugins View
  • you can debug source code of this extension with Hosted Plugin: Debug Instance command

Particularly for grunt you will need to study how to work with it, I've created an example project with from grunt-init-node. After you have it, you should compare experience in Theia and VS Code. VS Code users should not be lost. You can also find some articles for working with grunt in VS Code and try to follow along them with Theia.

@elaihau
Copy link
Contributor

elaihau commented Feb 6, 2019

Thank you @akosyakov !

I followed the instructions to have the grunt extension built, copied to theia/plugins, and shown up in the plugins view.

With a project, where the grunt tasks are defined, opened in theia, I was able to see similar items from 'Run Tasks'.

@elaihau
Copy link
Contributor

elaihau commented Feb 6, 2019

For people interested in reproducing what Anton did:

  1. To get the code, run the following commands
$ git clone https://github.com/theia-ide/vscode-builtin-extensions.git
$ cd vscode-builtin-extensions
$ git submodule init
$ git submodule update
  1. install all the dependencies https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites
  2. run yarn from vscode-builtin-extensions

vince-fugnitto added a commit to vince-fugnitto/vscode-builtin-extensions that referenced this issue Feb 7, 2019
Update readme to reflect complete steps to
properly build the repository eclipse-theia/theia#4216 (comment)

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@elaihau
Copy link
Contributor

elaihau commented Feb 7, 2019

  • you can debug source code of this extension with Hosted Plugin: Debug Instance command

and from this github issue we can find more details on how to debug the theia plugins & vscode extensions: #3251

@elaihau elaihau self-assigned this Feb 11, 2019
akosyakov pushed a commit to eclipse-theia/vscode-builtin-extensions that referenced this issue Feb 28, 2019
Update readme to reflect complete steps to
properly build the repository eclipse-theia/theia#4216 (comment)

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@akosyakov
Copy link
Member Author

akosyakov commented Mar 27, 2019

I've just tried grunt extension with grunt init example within #4714 and it does not detect tasks at all.

Updated: I got it working after reloading browse several times, it seems there are still some lifecycle issues.

@elaihau
Copy link
Contributor

elaihau commented Aug 29, 2019

tasks contributed by npm, grunt, gulp, jake, typescript-language-features now work in theia.

could we close this issue if i am not missing anything ?
@akosyakov

@akosyakov
Copy link
Member Author

@elaihau thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants