bug: failure to build using 'next' packages #7974

vince-fugnitto · 2020-06-06T15:13:23Z

Bug Description:

The application fails to build when using next packages (as also viewed from theia-apps). When attempting to 'compose an application', the build results in the following failure:

$ yarn run clean && yarn build && yarn run download:plugins
yarn run v1.22.4
$ theia clean
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module '../lib/theia'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/evinfug/Desktop/test-app/node_modules/@theia/cli/bin/theia:2:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Steps to Reproduce:

If one wants to reproduce, you can simply follow the steps provided in composing applications.

create a directory, and a package.json inside of it
update the package.json to include the following:

{
  "private": true,
  "dependencies": {
      "@theia/callhierarchy": "next",
      "@theia/file-search": "next",
      "@theia/git": "next",
      "@theia/json": "next",
      "@theia/markers": "next",
      "@theia/messages": "next",
      "@theia/mini-browser": "next",
      "@theia/navigator": "next",
      "@theia/outline-view": "next",
      "@theia/plugin-ext-vscode": "next",
      "@theia/preferences": "next",
      "@theia/preview": "next",
      "@theia/search-in-workspace": "next",
      "@theia/terminal": "next"
  },
  "devDependencies": {
      "@theia/cli": "next"
  },
  "scripts": {
      "prepare": "yarn run clean && yarn build && yarn run download:plugins",
      "clean": "theia clean",
      "build": "theia build --mode development",
      "start": "theia start --plugins=local-dir:plugins",
      "download:plugins": "theia download:plugins"
  },
  "theiaPluginsDir": "plugins",
  "theiaPlugins": {
      "vscode-builtin-css": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/css-1.39.1-prel.vsix",
      "vscode-builtin-html": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/html-1.39.1-prel.vsix",
      "vscode-builtin-javascript": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/javascript-1.39.1-prel.vsix",
      "vscode-builtin-json": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/json-1.39.1-prel.vsix",
      "vscode-builtin-markdown": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/markdown-1.39.1-prel.vsix",
      "vscode-builtin-npm": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/npm-1.39.1-prel.vsix",
      "vscode-builtin-scss": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/scss-1.39.1-prel.vsix",
      "vscode-builtin-typescript": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/typescript-1.39.1-prel.vsix",
      "vscode-builtin-typescript-language-features": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/typescript-language-features-1.39.1-prel.vsix"
  }
}

perform yarn and notice the error

Additional Information

yarn: v1.22.4

The text was updated successfully, but these errors were encountered:

thegecko · 2020-06-07T12:19:37Z

This is due to the lib folder missing on @next releases since d9a0973.

It doesn't look like that PR caused an issue, that's just when it started happening.
I've confirmed the @theia/cli and @theia/core packages (at least) are missing the lib folders since this version.

thegecko · 2020-06-07T12:48:11Z

Looking at the build job from then, I can't see how theia is even built before deploy, the step which does it is skipped.

I assume therefore, we load it from cache somewhere/somehow. I'll stop my investigation here as I'm sure there are others with a better understanding of the CI setup :)

akosyakov · 2020-06-08T06:33:06Z

It could be that something went wrong with npm/yarn during last publishing and next publishing will fix it.

thegecko · 2020-06-08T07:09:39Z

It could be that something went wrong with npm/yarn during last publishing and next publishing will fix it.

There has been a publish since then which didn't fix it :(

marcdumais-work · 2020-06-08T15:44:10Z

I just tried building a next theia app, that it built. I also confirm I see the lib folder for the core and cli extensions, so it looks like the publish is normal again? Can someone confirm?

vince-fugnitto · 2020-06-08T15:44:52Z

I just tried building a next theia app, that it built. I also confirm I see the lib folder for the core and cli extensions, so it looks like the publish is normal again? Can someone confirm?

I'll restart the cron on theia-apps and hopefully it passes :)

marcdumais-work · 2020-06-08T16:06:01Z

I think we have at least one new problem, seemingly related to ripgrep:

598error /home/theia/node_modules/vscode-ripgrep: Command failed.
599Exit code: 1
600Command: node ./lib/postinstall.js
601Arguments: 
602Directory: /home/theia/node_modules/vscode-ripgrep
603Output:
604internal/modules/cjs/loader.js:638
605    throw err;
606    ^
607
608Error: Cannot find module 'proxy-from-env'
609    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
610    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
611    at Module.require (internal/modules/cjs/loader.js:692:17)
612    at require (internal/modules/cjs/helpers.js:25:18)
613    at Object.<anonymous> (/home/theia/node_modules/vscode-ripgrep/lib/download.js:11:24)
614    at Module._compile (internal/modules/cjs/loader.js:778:30)
615    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
616    at Module.load (internal/modules/cjs/loader.js:653:32)
617    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
618    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
619info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
620The command '/bin/sh -c yarn --pure-lockfile &&     NODE_OPTIONS="--max_old_space_size=4096" yarn theia build &&     yarn theia download:plugins &&     yarn --production &&     yarn autoclean --init &&     echo *.ts >> .yarnclean &&     echo *.ts.map >> .yarnclean &&     echo *.spec.* >> .yarnclean &&     yarn autoclean --force &&     yarn cache clean' returned a non-zero code: 1
621The command "./build_container.sh $NPM_TAG $IMAGE_NAME $NODE_VERSION $PORT $ENV_VARS" failed and exited with 1 during .

It happens that a new version was released yesterday, and yet another new one today:

'1.5.9': '2020-06-07T19:20:36.052Z'
'1.6.0': '2020-06-08T14:12:13.919Z'

marcdumais-work · 2020-06-08T16:11:30Z

I assume the yarn.lock is currently insulating the main repo from the issue above, pinning ripgrep to an earlier version vs what we pull in theia-apps.

marcdumais-work · 2020-06-08T16:25:47Z

New issue opened on vscode-ripgrep: microsoft/vscode-ripgrep#13

marcdumais-work · 2020-06-08T16:33:12Z

As a temporary work-around for affected apps, we could use a resolutions block that pins vscode-ripgrep to 1.5.8.

marcdumais-work · 2020-06-08T17:28:05Z

Looks to be fixed in vscode-ripgrep v1.6.1

marcdumais-work · 2020-06-08T18:56:09Z

Closing this issue for now - I think we do not know exactly what caused it, but it seems gone. Please re-open if not.

cdietrich · 2020-10-16T09:02:36Z

this seems to happen again

cdietrich · 2020-10-16T09:03:50Z

yarn run v1.22.4
$ /Users/cdietrich/git/xtext-languageserver-example/theia-vscode/node_modules/.bin/theia build
internal/modules/cjs/loader.js:984
  throw err;
  ^

Error: Cannot find module '../lib/theia'
Require stack:
- /Users/cdietrich/git/xtext-languageserver-example/theia-vscode/node_modules/@theia/cli/bin/theia
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:981:15)
    at Function.Module._load (internal/modules/cjs/loader.js:863:27)
    at Module.require (internal/modules/cjs/loader.js:1043:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/Users/cdietrich/git/xtext-languageserver-example/theia-vscode/node_modules/@theia/cli/bin/theia:2:1)
    at Module._compile (internal/modules/cjs/loader.js:1157:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1177:10)
    at Module.load (internal/modules/cjs/loader.js:1001:32)
    at Function.Module._load (internal/modules/cjs/loader.js:900:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/cdietrich/git/xtext-languageserver-example/theia-vscode/node_modules/@theia/cli/bin/theia'
  ]
}

cdietrich · 2020-10-16T09:32:36Z

seems to have selfrepaired

vince-fugnitto added the bug bugs found in the application label Jun 6, 2020

This was referenced Jun 6, 2020

Add dart sdk to full image and install dart and flutter extensions to next image theia-ide/theia-apps#369

Merged

Next version of theia applications do not build theia-ide/theia-apps#371

Closed

thegecko mentioned this issue Jun 7, 2020

Added Travis CI jobs to publish installers theia-ide/theia-apps#370

Merged

akosyakov added the ci issues related to CI / tests label Jun 8, 2020

akosyakov mentioned this issue Jun 8, 2020

Unable to run theia for the first time #6370

Closed

marcdumais-work closed this as completed Jun 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug: failure to build using 'next' packages #7974

bug: failure to build using 'next' packages #7974

vince-fugnitto commented Jun 6, 2020

thegecko commented Jun 7, 2020

thegecko commented Jun 7, 2020

akosyakov commented Jun 8, 2020

thegecko commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

vince-fugnitto commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020 •

edited

Loading

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

cdietrich commented Oct 16, 2020

cdietrich commented Oct 16, 2020

cdietrich commented Oct 16, 2020

bug: failure to build using 'next' packages #7974

bug: failure to build using 'next' packages #7974

Comments

vince-fugnitto commented Jun 6, 2020

Bug Description:

Steps to Reproduce:

Additional Information

thegecko commented Jun 7, 2020

thegecko commented Jun 7, 2020

akosyakov commented Jun 8, 2020

thegecko commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

vince-fugnitto commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020 • edited Loading

marcdumais-work commented Jun 8, 2020

marcdumais-work commented Jun 8, 2020

cdietrich commented Oct 16, 2020

cdietrich commented Oct 16, 2020

cdietrich commented Oct 16, 2020

marcdumais-work commented Jun 8, 2020 •

edited

Loading