Add dart sdk to full image and install dart and flutter extensions to next image

[chrbayer]

Please review. One drawback is that the dart SDK is installed to Dockerimage for stable and next image.

[chrbayer]

This fixes #368.

[vince-fugnitto]

Is there a reason that latest was not updated?

[chrbayer]

I have not added it to latest because it did not want to make this change for latest, the idea was to wait until next is getting latest. Do you think I should make the change in latest, too?

[vince-fugnitto]

I have not added it to latest because it did not want to make this change for latest, the idea was to wait until next is getting latest. Do you think I should make the change in latest, too?

@chrbayer don’t see why we wouldn’t add the functionality to both images, they both should have the proper functionality to make use of the new vscode extensions introduced by the pull-request.

Please be sure to properly squash your commits when you’re ready for a re-review :)

[chrbayer]

Thanks for the review :-) I have added the plugins to the latest image, too. The pull request should be complete now.

But there was a problem with downloading repgrep, I had the same problem with ci and my local builds... This seem to work again.

But now it fails Error: Cannot find module '../lib/theia' on next image...
I had the same problem with this image before my changes, therefore I opened #371,
see eclipse-theia/theia#7974

[chrbayer]

This should be final now if nothing is found in the review.

[marcdumais-work]

But there was a problem with downloading repgrep, I had the same problem with ci and my local builds... This seem to work again.

Indeed - the latest ripgrep was momentarily broken. It's now fixed. See microsoft/vscode-ripgrep#13

[marcdumais-work]

Thanks @chrbayer . @vince-fugnitto ready for a final review on this one?

[chrbayer]

@marcdumais-work Ready from my side. Thanks in advance!

[vince-fugnitto]

@chrbayer do you mind squashing your commits (into a single commit) so we can accept the changes? :)

[chrbayer]

@vince-fugnitto Of course, I will do it :-)

[marcdumais-work]

@chrbayer I think the commit message needs an update to reflect the current content. I suggest something like:
[full] Add dart to latest and next images
or simply:
[full] Add dart

[marcdumais-work]

Awesome, thanks for the update @chrbayer

@vince-fugnitto Can you have another look, and if no further comments, merge?

[vince-fugnitto]

The changes look good, and the CI successfully passed 👍
Thank you for the contribution!