fix: return focus to least recently active tab #10533 #10685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com>
colin-grant-work
added
bug
Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com>
colin-grant-work
approved these changes
Jan 31, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10533: When the last tab of a TabBar is closed, always the last tab of the previous TabBar is activated.
This behavior differs from VSCode - the previously opened tab stays open.
10533_issue.mp4
How to test
10533_fixed.mp4
Review checklist
Reminder for reviewers
I couldn't spot any existing tests regarding the TabBar behavior - if i have missed them, please let me know. Locally my tests are passing for the core package.