Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog: adding maxWidth to SingleTextInputDialog #12642

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

vladarama
Copy link
Contributor

What it does

This PR adds a maxWidth attribute to SingleTextInputDialogs in order to fix a styling issue that would occur when the input validation error message would get too long. This would cause the dialog to extend indefinitely. This fix adds a max-width of 400 px to the dialogs to make their styling more user-friendly. The modified dialogs include: New File, New Folder, Rename and EditKeybinding dialogs.

Before:
no maxwidth

After:
maxwidth

How to test

  1. Open Theia application
  2. Try causing errors while renaming files, creating new files/folders, modifying keybindings
  3. The dialog should have a max-width: 400px css style
  4. Long error messages should not extend the dialog indefinitely

Easy errors to test include: creating a file/folder with no name or a duplicate name,
renaming a file to the same name, creating empty key bindings ...

Should be merged after #12585

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me 👍

@msujew msujew merged commit becfd76 into eclipse-theia:master Jul 5, 2023
7 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.40.0 milestone Jul 27, 2023
@vladarama vladarama deleted the maxwidth-dialogs branch July 31, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants