Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add focus style to items in getting started page #6162

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

kpge
Copy link
Contributor

@kpge kpge commented Sep 11, 2019

What it does

fix: #6157
image

How to test

  • open Getting Started page
  • press tab to select one item and press enter to click it

Review checklist

Reminder for reviewers

Signed-off-by: kpge <gekangping@126.com>
@kpge kpge added the getting-started issues related to the getting-started extension label Sep 11, 2019
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @kpge ! 👍
I tested navigating the getting-started page using tab, and thanks to the outline
it was much easier.

@vince-fugnitto vince-fugnitto merged commit 98f12a9 into eclipse-theia:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getting-started issues related to the getting-started extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't kown which item is selected when press tab in getting start page
2 participants