Minor fix for the command palette filter

[olexii4]

Signed-off-by: Oleksii Orel oorel@redhat.com

What it does

Add the trim options to the command palette filter.

How to test

How to reproduce a bug:

1. Press 'f1' and try to find 'git' commands. It won't work if you add a space after the prefix.
   

Visual Studio Code has another behavior:

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[olexii4]

@akosyakov I have finished. WDYT?

[vince-fugnitto]

@olexii4 do you know of a case when the trim would be set to false?

[olexii4]

@vince-fugnitto I do not know any case when the trim would be set to false. I just didn't want to limit what was implemented.

Do you think I should add trim as a general behavior?

[vince-fugnitto]

@vince-fugnitto I do not know any case when the trim would be set to false. I just didn't want to limit what was implemented.

Do you think I should add trim as a general behavior?

Exactly, I was just wondering if we should trim in all cases (without the flag). I'm wondering if it'd be useful to turn it off, and in what use case.

[olexii4]

@akosyakov WDYT?

[akosyakov]

Thank you for changes!

@olexii4 @vince-fugnitto if there is not case for false, i would be fine to trim it always and introduce a flag when we actually need it.

@vince-fugnitto Could you finish a review please? I would be fine with both ways.

[olexii4]

@vince-fugnitto Do you prefer to trim in all cases (without the flag)?

PS
I would be fine with both ways too.

[vince-fugnitto]

@vince-fugnitto Do you prefer to trim in all cases (without the flag)?

PS
I would be fine with both ways too.

I'd be fine both ways as well, I'm not sure if it anyone would turn it off explicitly but we can always have the option. I'll test the functionality when I have a bit of time :)

[vince-fugnitto]

It works well for me 👍
I think we can go with either approach:

1. always trim
2. trim based on the option

I'll leave it up to you @olexii4 :)

[olexii4]

Let's leave as is.

[olexii4]

@akosyakov Could you finish a review, please?