-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix for the command palette filter #6225
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@akosyakov I have finished. WDYT? |
@olexii4 do you know of a case when the |
@vince-fugnitto I do not know any case when the trim would be set to false. I just didn't want to limit what was implemented. Do you think I should add |
Exactly, I was just wondering if we should trim in all cases (without the flag). I'm wondering if it'd be useful to turn it off, and in what use case. |
@akosyakov WDYT? |
Thank you for changes! @olexii4 @vince-fugnitto if there is not case for false, i would be fine to trim it always and introduce a flag when we actually need it. @vince-fugnitto Could you finish a review please? I would be fine with both ways. |
@vince-fugnitto Do you prefer to trim in all cases (without the flag)? PS |
I'd be fine both ways as well, I'm not sure if it anyone would turn it off explicitly but we can always have the option. I'll test the functionality when I have a bit of time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well for me 👍
I think we can go with either approach:
- always trim
- trim based on the
option
I'll leave it up to you @olexii4 :)
Let's leave as is. |
@akosyakov Could you finish a review, please? |
Signed-off-by: Oleksii Orel oorel@redhat.com
What it does
Add the trim options to the command palette filter.
How to test
How to reproduce a bug:
Visual Studio Code has another behavior:
![Screenshot from 2019-09-20 06-06-14](https://user-images.githubusercontent.com/6310786/65297464-9c808800-db70-11e9-97f9-8f341242e9f0.png)
Review checklist
Reminder for reviewers