Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] don't wrap promise in promise #6290

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Sep 29, 2019

What it does

Fixes a bug where command execution result was wrapped in an extra promise.

How to test

Install a vscode extension that executes a command expecting a result.
E.g. built-in emmet runs unsupported vscode.executeDocumentSymbolProvider https://github.com/microsoft/vscode/blob/8cafaf5900ac9765a6946ce9c660da54846d9d07/extensions/emmet/src/defaultCompletionProvider.ts#L166

Review checklist

Reminder for reviewers

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@svenefftinge svenefftinge merged commit 9eb699b into master Sep 30, 2019
@svenefftinge svenefftinge deleted the se/promise_in_promise branch September 30, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants