-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass pluginInfo through to output channel append method #6312
Pass pluginInfo through to output channel append method #6312
Conversation
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@@ -991,7 +991,7 @@ export interface PreferenceRegistryExt { | |||
} | |||
|
|||
export interface OutputChannelRegistryMain { | |||
$append(channelName: string, value: string): PromiseLike<void>; | |||
$append(channelName: string, value: string, pluginInfo: PluginInfo): PromiseLike<void>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I have two comments:
- should we make
pluginInfo
optional? - should it simply be in the form of
options? any
so we can potentially pass more in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we could make it optional, but I was just following what I did in: f25652a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay fair enough :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise looks good to me, output channels still work
Only worry about additional information to send, but it can be optimized when we have a real issue.
@akosyakov Is it okay to merge or should we wait for @evidolob and @benoitf to take a look |
@JPinkney it is fine with me to merge |
you can merge |
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What it does
This PR passes the pluginInfo through to the output-channel-registry-main $append method.
This is needed for https://github.com/eclipse-theia/theia/pull/6303/files#r330382601 to make the language plugins we can get metrics from more dynamic.
How to test
Put a breakpoint https://github.com/eclipse-theia/theia/compare/master...JPinkney:pass-plugin-info-output-registry?expand=1#diff-11ebe3cff728b3126a471050a7378864L37 and launch the browser backend/frontend. Then install vscode java. When it's installed and starts outputting to the output channel the breakpoint will be hit. Inspect the pluginInfo variable and you will find the pluginInfo that was passed through.
Review checklist
Reminder for reviewers