Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "group" in the task config #6522

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Conversation

elaihau
Copy link
Contributor

@elaihau elaihau commented Nov 10, 2019

Signed-off-by: Liang Huang liang.huang@ericsson.com

How to test

Use case 1:

  • prepare a workspace where configured and detected tasks are defined
  • add "group": "build" to task configs in tasks.json
  • start "run build task" from the top menu bar "Terminal -> Run build task..."
  • check if all task configs that are marked as "build tasks" are available from the list populated by the previous step, and if they can be run.

Peek 2019-11-10 09-53

Use case 2:

  • prepare a workspace where configured and detected tasks are defined
  • ensure there are no task configs marked as "build tasks"
  • start "run build task" from the top menu bar "Terminal -> Run build task..."
  • Check if an action populated - once clicked there should be a list of tasks presented for the user to select which task would be configured as the "default build task"
  • Once the "default build task" is chosen, and "run build task" is started, the default build task should be run automatically.

Peek 2019-11-10 09-54

Review checklist

@akosyakov akosyakov added tasks issues related to the task system vscode issues related to VSCode compatibility labels Nov 11, 2019
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general everything works great :)

A few things I noticed:

  1. when configuring the default build task through the menu item, I think we should open the tasks.json as well like VS Code
  2. when configuring the default test task through the menu item, I think we should open the tasks.json as well like VS Code
  3. if a workspace has no tasks present, should we add better user feedback when they try and execute run build task and run test task? (perhaps similarly as run task display no tasks found)

@elaihau
Copy link
Contributor Author

elaihau commented Nov 11, 2019

Thank you for the review @vince-fugnitto !
I resolved your comments. See you in office later (if you are in office)!

@vince-fugnitto
Copy link
Member

Thank you for the review @vince-fugnitto !
I resolved your comments. See you in office later (if you are in office)!

See you soon! 😃

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a follow-up issue which I think we can improve in the future: #6525
I noticed one discrepancy between our implementation and VS Code.
Do we want to cover it during this PR or as an enhancement later?

Scenario

  • Configure two different tasks as the default build tasks
    • Theia: executes the first default build task
    • VS Code: prompts users to select the build task

- With this change users would be able to define and run build tasks,
test tasks, default build tasks, and default test tasks.
- resolves #6144

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau
Copy link
Contributor Author

elaihau commented Nov 11, 2019

I resolved the issue where multiple default build/test tasks are defined in the config.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly for me 😄
Thank you for making the adjustments!

@elaihau elaihau merged commit cdabeb1 into master Nov 12, 2019
@elaihau elaihau deleted the Liang/run_build_test_task branch November 12, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tasks] support 'group' in tasks
3 participants