[plugin] fix executeCommand arguments passing #6537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
added
typescript
|
testing right now... |
AlexTugarev
approved these changes
Nov 13, 2019
AlexTugarev
reviewed
Nov 13, 2019
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
se/plugin_executeCommand_fix
branch
from
cff5bb5
to
51e9bff
Compare
|
Works nicely! |
|
OSX build failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes passing of arguments for
executeCommand.How to test
Install typescript-language-features builtin and see how the commands (prefixed with 'TypeScript:' do not appear when a ts file is active without this change.
Review checklist
Reminder for reviewers