[core] Don't scroll when re-setting focus on widgets. #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#4901 Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
requested review from
JanKoehnlein,
jbicker,
akosyakov and
AlexTugarev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes annoying scrolling issues in scrollable widgets, that occur when using context menu or the quick open functionality.
Fixes #4901
How to test
In navigator scroll down, so you no longer see the first item.
Then open context menu or quick open and escape again (or choose an action). In current master the navigator will be scrolled back to zero. With this PR the scrolling state doesn't change.
Review checklist
Reminder for reviewers