Add implementation for env.shell plugin API #6657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
reviewed
Nov 28, 2019
| @@ -115,6 +115,15 @@ export class TerminalServiceExtImpl implements TerminalServiceExt { | |||
| this.onDidChangeActiveTerminalEmitter.fire(this.activeTerminal); | |||
| } | |||
|
|
|||
| private defauleShell: string; | |||
There was a problem hiding this comment.
Suggested change
| private defauleShell: string; | |
| private defaultShell: string; |
akosyakov
added
plug-in system
akosyakov
reviewed
Nov 29, 2019
akosyakov
approved these changes
Nov 29, 2019
AndrienkoAleksandr
approved these changes
Nov 29, 2019
Signed-off-by: svor <vsvydenk@redhat.com>
|
please merge as soon as build is green, recently it takes a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: svor vsvydenk@redhat.com
What it does
This PR provides an implementation for env.shell VS Code API.
It is needed for eclipse-che/che#15116
How to test
It can be tested with VS Code Quarkus extension.
The terminal will be opened and extension should start installing
Review checklist
Reminder for reviewers