GH-6499: Explicitly close the socket onStop
in electron
#6681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the channels will be closed with a
checkAliveTimeout
delayin the electron application, when refreshing the browser window.
Closes: #6499
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
/search-in-workspace
->/services/search-in-workspace
.How to test
I do not have a clean way to verify it, but you can add some logging to backend on
JsonRpcProxy#onDidCloseConnection
. See #6499.Review checklist
Reminder for reviewers
I am going to verify the behavior on Windows.