Check partial keybindings to match current context #6752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Check partial keybindings to match current context. VsCode uses the same approach: https://github.com/microsoft/vscode/blob/1bf341e6d2b0963e6260853e570d2655f987ffcb/src/vs/platform/keybinding/common/keybindingResolver.ts#L279-L292
They look for a suitable command by checking the context before viewing partial keybinding notification in the status bar
How to test
Vim
plugin by executingF1 => Vim: Toggle Vim Mode
g
key.See that the status bar didn't change.
Theia at current master state shows a notification in the the status bar, that the first part of the keybinding was pressed.
Review checklist
Reminder for reviewers