Add info about processId and terminalId to TaskExitedEvent #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
vince-fugnitto
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
It looks the information is available in VS Code for all task events so I'm fine with the changes to make things easier: https://github.com/microsoft/vscode/blob/5418a564230e42b2f582f8ff961200eb052b695c/src/vs/workbench/contrib/tasks/common/tasks.ts#L970-L980
elaihau
approved these changes
Jan 6, 2020
paul-marechal
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add
processIdandterminalIdtoTaskExitedEvent.These fields are available in
TaskInfowhile a task is running, would be nice to have this info when a task is completed. It can be useful to find the corresponding terminal widget, for example.How to test
The PR changes do not provide a new functionality.
The fields are optional, so I think the PR doesn't bring the breaking changes.
Review checklist
Reminder for reviewers
Signed-off-by: Roman Nikitenko rnikiten@redhat.com