Keymaps: adjust keybindings-widget column spacing on firefox #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anasshahidd21
force-pushed
the
marginFix
branch
from
829edfb
to
a45f6cb
Compare
When opened in firefox, there is a large column for action buttons shown, reduced the size of the column just so it can be made consistent with other browsers. Issue ID: 6117 Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21
force-pushed
the
marginFix
branch
from
a45f6cb
to
307d312
Compare
|
@vince-fugnitto I made the change, and im ready for a re-review |
vince-fugnitto
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: 6117
When opened in firefox, there is a large column for action buttons shown, reduced the size of the column just so it can be made consistent with other browsers.
Signed-off-by: Muhammad Anas Shahid muhammad.shahid@ericsson.com
How to test
Try to open keyboard shortcuts on Firefox and Google Chrome(File>Settings>Open Keyboard Shortcuts )
Identify the difference in the size of the first column
This issue fixes the width of the column in Firefox and makes it equal with that of Chrome
Review checklist
Reminder for reviewers