API to create integration test pages #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
commented
Jan 31, 2020
| if (exit) { | ||
| await page.close(); | ||
| process.exit(failures > 0 ? 1 : 0); | ||
| const testPage = await newTestPage({ |
There was a problem hiding this comment.
@vince-fugnitto you will need something similar to test theia-apps, but it should spawn a server in the docker container
It enabled clients to control how the application is started and do any additional authentication if it is required. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
akosyakov/allow-passing-page-to-7028
branch
from
bec478b
to
595716d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Run
testandtest:debugcommands in the browser example and check that they still work.Review checklist
Reminder for reviewers