-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always use CommandService.execute
to run a command
#7326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vince-fugnitto not sure why it is not in the context menu, but i see it in the quick command palette. Could you file a follow-up issue please? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog with the breaking API changes. Thanks!
@kittaakos What is breaking? |
For instance: https://github.com/eclipse-theia/theia/pull/7326/files#diff-ab6e2d4c57658cf60e550cfe9ba87eacR304 |
I can, but i don't think it is practical. I am pretty sure that it is only client.
How is it going to break? It is a new field which is only used by |
Actually, it is not related to our |
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
fc3daf4
to
c3db052
Compare
@kittaakos I've made args optional, if it is turned out that someone called |
What it does
onWillExecute
were never triggered and the plugin system could not active pluginsonDidExecute
is added to support Monaco APIs properlyHow to test
Find All References
with a keybiding from ts fileReference Search
view should be opened and when ts is finished initialization references should appearReview checklist
Reminder for reviewers