Allow ripgrep to search files in hidden folders #7333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
vscode.workspace.findFiles ignores hidden folders.
How to test
Old behavior:
search result empty
Now:
.test/file.js in result of search
OS and Theia version:
MacOs Theia from master.
Diagnostics:
Arguments for search in theia:
theia/packages/file-search/src/node/file-search-service-impl.ts
Line 144 in 93ffbab
But vscode has --hidden: https://github.com/microsoft/vscode/blob/955ff025c39bcc919e7b828bc14239215f6b20ad/src/vs/workbench/services/search/node/ripgrepFileSearch.ts#L33
Review checklist