support presentation.showReuseMessage & clear in task config #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support presentation.showReuseMessage, which controls whether to show the "Terminal will be reused by tasks" message. - support presentation.clear, which controls whether the terminal is cleared before this task is run. Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
vince-fugnitto
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
I verified the changes and they look good 👍
clear=true successfully clears the terminal output before a new task is runclear=false successfully preserves the terminal output when a new task is runshowReuseMessage=true successfully displays the reuse messageshowReuseMessage=false successfully suppresses the reuse message
| @@ -103,11 +104,11 @@ export class TaskTerminalWidgetManager { | |||
| terminal.taskConfig = taskConfig; | |||
| terminal.busy = true; | |||
| } else { | |||
| this.notifyTaskFinished(terminal); | |||
| this.notifyTaskFinished(terminal, true); | |||
There was a problem hiding this comment.
I'm fine with being explicit and setting the reuse to true despite it being the default.
vince-fugnitto
added
tasks
RomanNikitenko
approved these changes
Apr 2, 2020
|
Thank you @RomanNikitenko and @vince-fugnitto ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liang Huang lhuang4@ualberta.ca
How to test
showReuseMessageorclearis defined in the task configExpected:
Terminal will be reused by tasksshows up after task finishesshowReuseMessage: falseinto the task config. Run task.Expected:
Terminal will be reused by tasksdoes not show up after task finishesclear: trueinto the task config. Run task.Expected:
Review checklist