#7451 [showSaveDialog] incompatible with VSCode #7461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vered Constantin vered.constantin@sap.com
Fixed API showSaveDialog to be compatible to VSCode in case URI does not exist.
What it does
Fixes #7451
The API should open a dialog in the following manner:
How to test
Explained in #issue7451
I created a simple vscode extension using this API: https://github.com/veredcon/vscodetests
Use this vsix:
vscode-ext-sample-0.0.3.zip
and follow the explanation as described in the issue itself.
Review checklist
Reminder for reviewers