application-package: show warning if user set unknown target and explicitly set it as browser

[maksimr]

Fixes #7559

Signed-off-by: Maksim Ryzhikov rv.maksim@gmail.com

What it does

Print warning if user set incorrect theia target and explicitly set it to “browser”

How to test

Set incorrect target in package.json or pass it as an option. For example {“theia”: {“target”: “foo”}}

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

code looks very clean, I have not tried to run though, someone has to test

[vince-fugnitto]

I correctly see the following message when attempting to use foo as a target.
We however log the message twice:

@theia/example-browser: yarn run v1.22.4
@theia/example-browser: $ theia build --mode development
@theia/example-browser: Unknown target 'foo', target 'browser' to be used instead
@theia/example-browser: Unknown target 'foo', target 'browser' to be used instead
...

[maksimr]

@vince-fugnitto I have relied on props cache so looks like ApplicationPackage instantiated twice. If there is a better place to put the code about warning it would be nice to know.

[akosyakov]

I have relied on props cache so looks like ApplicationPackage instantiated twice. If there is a better place to put the code about warning it would be nice to know.

ApplicationPackage created in theia-cli and expose-loader via webpack in 2 different processes, so it is kind of expected