Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for scm view #7818

Merged
merged 3 commits into from
May 15, 2020
Merged

fixes for scm view #7818

merged 3 commits into from
May 15, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

  • check that scm input has always proper min-height as before
  • check that on reload scm input is preserved
  • check that in the list mode there is no unnecessary left padding for file nodes
  • check that in the tree mode left padding is similar to padding for nodes in the navigator

Review checklist

Reminder for reviewers

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
also remove unnecessary padding in the list mode

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added the scm issues related to the source control manager label May 14, 2020
@akosyakov akosyakov added the ui/ux issues related to user interface / user experience label May 14, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍
I verified that:

  • the scm input is visible and has a correct minimum height
    • also verified it expands correctly when multiple lines are present
    • also verified that validation looks correct
  • the scm input is persisted when the application is reloaded
  • the padding for the entries is correct when using both the tree and list view modes

Copy link
Contributor

@westbury westbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the specific case in #7794 where a new workspace, never before opened, is opened. The input box is now immediately the correct height without having to update or anything to get the correct height. Thanks for fixing that.

@akosyakov akosyakov merged commit 79f3212 into master May 15, 2020
@akosyakov akosyakov deleted the akosyakov/scm-input-is-not-styled-7794 branch May 15, 2020 06:40
@akosyakov akosyakov mentioned this pull request May 15, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scm input is not styled properly
3 participants