[plugin] handle plugin host activation exceptions #8103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Jun 29, 2020
akosyakov
reviewed
Jun 29, 2020
| this.pluginActivationPromises.get(plugin.model.id)!.reject(err); | ||
| } | ||
| const message = `Activating extension '${plugin.model.displayName || plugin.model.name}' failed: ${err.message}`; | ||
| this.messageRegistryProxy.$showMessage(MainMessageType.Error, message, {}, []); |
There was a problem hiding this comment.
I was wondering maybe instead of using message service, we should have a special service then you can custoimize it in your product to completely stop the execution if some core extensions are failed, by default it will delegate to the notification center.
There was a problem hiding this comment.
I like this idea, but it feels like a separate PR to change architecture rather than this bug fix.
I'll consider as the approach for our situation if that's OK?
Signed-off-by: Rob Moran <rob.moran@arm.com>
|
code looks good, but I have to check 2 cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rob Moran rob.moran@arm.com
What it does
Resolves #8018
Added catch to plugin host to handle exceptions thrown while resolving dependencies in plugins.
How to test
Follow steps in #8018
Review checklist
Reminder for reviewers