Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace json theia extension with vscode one #8112

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 29, 2020

What it does

Fixes: #7981
Fixes: #3983

  • fix 7981, fix 3983: replace json theia extension with vscode one
  • document breaking changes
  • deprecate contributing language support from Theia extension

Please see CHANGELOG for breaking changes.

How to test

Review checklist

Reminder for reviewers

@akosyakov akosyakov added json issues related to the json language languages issue related to languages plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Jun 29, 2020
@akosyakov akosyakov force-pushed the ak/json_vscode branch 5 times, most recently from 496d673 to 66b8039 Compare June 30, 2020 08:36
@akosyakov akosyakov requested a review from kittaakos June 30, 2020 08:39
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a difference when editing preferences in .theia vs .vscode.
When editing .vscode/settings.json I have more autocompletion or intelligence available, however for both I do not see the list of preferences I can update (compared to vscode).

theia:

theia

vscode:

vscode

@akosyakov
Copy link
Member Author

@vince-fugnitto How do you reproduce it. I've just tried latest state in Gitpod:
settings

Could you check terminal that VS Code extensions are downloaded successfully for you?

@vince-fugnitto
Copy link
Member

@vince-fugnitto How do you reproduce it. I've just tried latest state in Gitpod:

I re-verified and it works correctly now, I'm not sure how I got in that weird state before.

@akosyakov
Copy link
Member Author

It is required for #7100

@vince-fugnitto Could you have a look again please? Is there anything else should be addressed?

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akosyakov I verified the changes and they work well. I've verified that:

  • settings.json: both theia and vscode preferences has problem marker support and autocompletion
  • launch.json: both theia and vscode debug has problem marker support and autocompletion
  • keymaps.json: the entries are correctly populated like before, and the updates are applied correctly

I also looked over the code and did not see anything that looked incorrect.

@bd82
Copy link
Contributor

bd82 commented Jul 1, 2020

Hello @akosyakov

What is the behavior when multiple jsonSchemas are registered for an identical fileMatch pattern?
For example: If there is a schemaStore registration for xyz.json files and also a VSCode Ext with jsonContribution forh xyz.json?

Basically do jsonContribution replace schemaStore registrations or are they added as extra schemas?

@akosyakov
Copy link
Member Author

akosyakov commented Jul 2, 2020

Basically do jsonContribution replace schemaStore registrations or are they added as extra schemas?

They are added as extra schemas. You will need to check how json-language-featuers built-in extension handles it.

CHANGELOG.md Outdated Show resolved Hide resolved
@akosyakov
Copy link
Member Author

I'm updating deprecation notes with a link to VS Code docs about how to integrate a language server via VS Code extension and merging if there are no objections.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it in the context of Tasks functionality.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Use VS Code extensions instead: https://code.visualstudio.com/api/language-extensions/language-server-extension-guide

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov merged commit 8a029e2 into master Jul 2, 2020
@akosyakov akosyakov deleted the ak/json_vscode branch July 2, 2020 13:33
marcdumais-work added a commit to eclipse-theia/theia-website that referenced this pull request Jul 6, 2020
Fixes #118

Following PR eclipse-theia/theia#8112,
@theia/json should no longer be used. It's still present in the
doc here, and so will cause issues.

Signed-off-by: Marc Dumais <marc.dumais@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
json issues related to the json language languages issue related to languages plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
5 participants