branding: fix widget backgrounds (transparent) #8448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the following commit: - fixes the background for all widgets (so they do not have transparent backgrounds) - adds a branding example to `api-samples` for branding the icon, and main area. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
the
ui/ux
|
@vince-fugnitto Could you assign someone else for review? I won't have much time for reviews this month. |
GNSubrahmanyam
approved these changes
Sep 3, 2020
kittaakos
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Verified. Thank you!
verify that the menu icon is visible.
✅
verify that the branding icon is visible (when no content is present in the main area).
✅
verify (with multiple views/widgets) that the branding icon is not visible when content is present in the main area.
✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8444
The following pull-request updates the background of widgets in the framework so they are no longer
transparent.Previously, when there would be content behind views (such as a branding icon), the rendering would be incorrect.
The pull-request includes the following changes:
api-samples(main menu icon and branding icon)How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com