Make save as command not overwrite original file and open the new file. #8514
Conversation
…e. Signed-off-by: Leopold Eckert <leopoldwe@gmail.com>
vince-fugnitto
added
filesystem
| @@ -417,12 +417,18 @@ export class WorkspaceFrontendContribution implements CommandContribution, Keybi | |||
| } | |||
| } while (selected && exist && !overwrite); | |||
| if (selected) { | |||
| const temp = new URI(uri.toString() + '(copy).tmp'); | |||
There was a problem hiding this comment.
The variable temp is not used outside of the try block, therefore I think it should be placed inside.
| await this.commandRegistry.executeCommand(CommonCommands.CLOSE_TAB.id); | ||
| await open(this.openerService, selected); |
There was a problem hiding this comment.
Do we want to perform these operations even if there is an error in the try-catch?
Would it not be more valid to only perform these operations if the save was successful?
There was a problem hiding this comment.
Yes, it makes more sense that way. I put the statements inside the try block.
Signed-off-by: Leopold Eckert <leopoldwe@gmail.com>
| @@ -3,6 +3,7 @@ | |||
| ## v1.6.0 | |||
|
|
|||
| - [core] added functionality for handling context menu for `tab-bars` without activating the shell tab-bar [#6965](https://github.com/eclipse-theia/theia/pull/6965) | |||
| - [workspace] "save as" command does not save changes to old file and opens the new file. [#8514](https://github.com/eclipse-theia/theia/pull/8514) | |||
There was a problem hiding this comment.
Please be sure to update the changelog by rebasing it and placing it under the correct release (1.7.0).
# Conflicts: # CHANGELOG.md
Signed-off-by: Leopold Eckert <leopoldwe@gmail.com>
leopoldwe
force-pushed
the
stop-save-as-from-overwriting-original-file
branch
from
35a4117
to
f417f94
Compare
Signed-off-by: Leopold Eckert <leopoldwe@gmail.com>
There was a problem hiding this comment.
@leopoldwe the current approach does not work well, and results in weird behaviors:
- perform a
save ason a file and choose a location in the same workspace - the
(copy)file is visible in the UI (I would not expect this as an end-user) - the original file is also marked as
Deleted(by source control)
Signed-off-by: Leopold Eckert <leopoldwe@gmail.com>
|
I've tried to fix the source control problem, but I find it is outside of my abilities. I can't find a way to make the save as work and not a delete show in the source control temporarily. |
Signed-off-by: Leopold Eckert leopoldwe@gmail.com
What it does
Fixes #8373
Fixes #8504
When using the "save as" command, a new file will be created with the new changes, and the old file will be unchanged. The text editor will then close the old file and open the new one.
How to test
Review checklist
Reminder for reviewers