Use Named Listeners in DebugSession
#8616
Conversation
vince-fugnitto
added
debug
| @@ -759,4 +741,27 @@ export class DebugSession implements CompositeTreeElement { | |||
| return this.threads; | |||
| } | |||
|
|
|||
| protected handleContinued = ({ body: { allThreadsContinued, threadId } }: DebugProtocol.ContinuedEvent): void => { | |||
There was a problem hiding this comment.
From here:
only that good practice that doesn't hurt anything upstream
Let's make it return with Promise<void> so downstreams have greater flexibility on the code customization. Same for handleThread. What do you think?
There was a problem hiding this comment.
Sounds fair to me - I'll make the change.
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
colin-grant-work
force-pushed
the
extensibility/debug-session-event-handlers
branch
from
97b34e9
to
e99cd03
Compare
|
@colin-grant-work would you like to merge, I believe you have the proper permissions now :) |
|
@marcdumais-work I merged for Colin as I believe he did not have the proper permissions yet to do so despite now being a committer, is there some sync we need to perform on the repo rights? |
|
Hi, @colin-grant-work @kenneth-marut-work @Anasshahidd21 I think you may all be in the same situation. I see none of you listed as members of the
Please confirm that |
Signed-off-by: Colin Grant colin.grant@ericsson.com
What it does
This PR addresses #8614 with respect to the
DebugSessionby extracting the larger anonymous functions and assigning them to member variables. At present, it would be necessary to override the whole constructor to change any individual listener, and that makes it more difficult for adopters to keep in synch with changes upstream.Pros:
Cons:
How to test
It should have no effect on application behavior.
Review checklist
Reminder for reviewers