Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for secondary button text not visible in light theme #9008

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

balajiv113
Copy link
Contributor

@balajiv113 balajiv113 commented Jan 30, 2021

Signed-off-by: Balaji V kuttibalaji.v6@gmail.com

What it does

Fixes #9006

How to test

Follow the steps given in the issue

Review checklist

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balajiv113 thank you for providing a fix for the styling, do you mind reverting the unnecessary changes (formatting) since it adds noise to the pull-request and makes it more difficult to review. Else, you can group the formatting changes in a secondary commit 👍

@vince-fugnitto vince-fugnitto added bug bugs found in the application ui/ux issues related to user interface / user experience labels Jan 30, 2021
@balajiv113
Copy link
Contributor Author

@vince-fugnitto Grouped the changes into 2 separate commits as mentioned.

Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the scenario from the issue and Pull Requests comments. Works as expected. Thank you @balajiv113

@vince-fugnitto
Copy link
Member

@balajiv113 do you mind rebasing the pull-request on the latest master (it should resolve the build errors).

Signed-off-by: Balaji V <kuttibalaji.v6@gmail.com>
Signed-off-by: Balaji V <kuttibalaji.v6@gmail.com>
@balajiv113
Copy link
Contributor Author

@vince-fugnitto Re-based with current master 👍

@vince-fugnitto
Copy link
Member

@vince-fugnitto Re-based with current master 👍

Thank you for your contribution, and being responsive :)

@vince-fugnitto vince-fugnitto merged commit 925c0db into eclipse-theia:master Feb 3, 2021
@balajiv113 balajiv113 deleted the BUG-9006 branch February 3, 2021 16:52
@paul-marechal paul-marechal added this to the 1.11.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secondary Button text not visible in light theme
4 participants