Feat/add validation to golden record process in pool #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainer-exxcellent
changed the title
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_bos
branch
from
1a712a8
to
42dbe24
Compare
rainer-exxcellent
changed the title
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_bos
branch
2 times, most recently
from
5f146b9
to
a9c744b
Compare
nicoprow
requested changes
Nov 28, 2023
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
martinfkaeser
suggested changes
Nov 28, 2023
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_bos
branch
from
a9c744b
to
6363bc5
Compare
| * Merge Maps with collections as values. | ||
| * The collections with the same key in the different maps are concatenated | ||
| */ | ||
| fun <KEY, VALUE> mergeMapsWithCollectionInValue( |
There was a problem hiding this comment.
Maybe name it mergeMultiMaps?
https://en.wikipedia.org/wiki/Multimap
There was a problem hiding this comment.
The core of the functionality is that the collections in the value part of the map are concatenated.
This should be expressed in the name.
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/BusinessPartnerBuildService.kt
Outdated
Show resolved
Hide resolved
...ool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskStepFetchAndReserveService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_bos
branch
from
6363bc5
to
16e342d
Compare
nicoprow
approved these changes
Dec 6, 2023
|
@martinfkaeser from your prerspective are there still open points that need to be addressed in this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upsert Business Partners from Cleaning Result - implement validation for legel entities, sites and addresses
add validation to the golden record process
fix validation of address identifiers
Tests are moved to the next step
Solves: #556