Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool: Upsert Business Partners from Cleaning Result - refactor, add validation and test #556

Closed
rainer-exxcellent opened this issue Oct 24, 2023 · 0 comments
Closed

Pool: Upsert Business Partners from Cleaning Result - refactor, add validation and test #556

rainer-exxcellent opened this issue Oct 24, 2023 · 0 comments
Assignees
@rainer-exxcellent
Labels
Pool Issues which relate to the Pool application or its API definition

Comments

@rainer-exxcellent
Copy link
Contributor

To complete the Issue:

#432

we need the following tasks:

  • refactor code so that the pool and orchestrator logic use the same code
  • implement validation logic for insert/update of legal entities, sites and addresses
  • add test for the cleaning the pool
@rainer-exxcellent rainer-exxcellent changed the title Pool: Upsert Business Partners from Cleaning Result - refactore, add validation and test Pool: Upsert Business Partners from Cleaning Result - refactor, add validation and test Oct 24, 2023
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Oct 25, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
bb70ae1 
…ng Result

- refactor validation and persistence
@rainer-exxcellent rainer-exxcellent mentioned this issue Oct 25, 2023
Merged
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Oct 27, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
af5bbb3 
…ng Result

- refactor validation and persistence
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Oct 31, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
6c709db 
…ng Result

- refactor validation and persistence
@nicoprow nicoprow added the Pool Issues which relate to the Pool application or its API definition label Oct 31, 2023
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Oct 31, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
38c4493 
…ng Result

- add tests to upsert site
@rainer-exxcellent rainer-exxcellent mentioned this issue Oct 31, 2023
Merged
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 8, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
9066e5b 
…ng Result

- refactor validation and persistence
nicoprow added a commit that referenced this issue Nov 9, 2023
@nicoprow
Merge pull request #558 from catenax-ng/refactor/orchestrator_pool_dtos
1744943 
feat(pool): #556 Upsert Business Partners from Cleaning Result - refactoring
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 9, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
9347ec2 
…ng Result

- add tests to upsert legal entities, site and addresses
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 14, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
70af9be 
…ng Result

- refactor validation
@rainer-exxcellent rainer-exxcellent mentioned this issue Nov 14, 2023
Merged
2 tasks
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 15, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Upsert Business Partners from Cleani…
1a712a8 
…ng Result

- implement validation for golden record process
@rainer-exxcellent rainer-exxcellent mentioned this issue Nov 15, 2023
Merged
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 21, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Refactor RequestValidationService
fc44a12
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 21, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 Refactor RequestValidationService
2b83f8d
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 23, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 implement validation for golden reco…
81550b3 
…rd process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 23, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 add test for validation in golden re…
10f05ab 
…cord process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 23, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 fix validation for address identifier
42dbe24
nicoprow added a commit that referenced this issue Nov 23, 2023
@nicoprow
Merge pull request #619 from catenax-ng/refactor/orchestrator_pool_va…
1f2f63d 
…lidations

feat(pool): #556 Upsert Business Partners from Cleaning Result - refactor validation
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 27, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 implement validation for golden reco…
5f146b9 
…rd process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 27, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 implement validation for golden reco…
a9c744b 
…rd process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 27, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 write test for pool validation in go…
0842e0e 
…lden record process
@rainer-exxcellent rainer-exxcellent mentioned this issue Nov 27, 2023
Merged
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 29, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 implement validation for golden reco…
6363bc5 
…rd process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 29, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 implement validation for golden reco…
24db75a 
…rd process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Nov 29, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 write test for pool validation in go…
d97e202 
…lden record process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Dec 6, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 implement validation for golden reco…
16e342d 
…rd process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Dec 7, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 write test for pool validation in go…
32e43e7 
…lden record process
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Dec 7, 2023
@rainer-exxcellent
feat(pool): eclipse-tractusx#556 write test for pool validation in go…
9e00fee 
…lden record process
@nicoprow nicoprow closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rainer-exxcellent rainer-exxcellent

Labels
Pool Issues which relate to the Pool application or its API definition
Projects
BPDM Kanban
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicoprow @rainer-exxcellent