-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue fix 401 #402
base: main
Are you sure you want to change the base?
Issue fix 401 #402
Conversation
Validation Report for io.catenax.single_level_bom_as_specified/2.0.1/SingleLevelBomAsSpecified.ttlInput model is valid |
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>. | ||
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>. | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>. | ||
@prefix : <urn:samm:io.catenax.single_level_bom_as_specified:2.0.0#>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to create new model, then please change the version here to 2.0.1
Validation Report for io.catenax.single_level_bom_as_specified/2.0.1/SingleLevelBomAsSpecified.ttlInput model is valid |
samm:preferredName "Manufacturer ID"@en; | ||
samm:description "The ID of the initial issuer of the single level BoMAsSpecified"@en; | ||
samm:characteristic samm-c:Text; | ||
samm:exampleValue "BPNL1234567890LR". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the text property where you can store any value or only BPNL number? if only bpnl number, then I would suggest to use shared aspect model, example: https://github.com/eclipse-tractusx/sldt-semantic-models/pull/405/files#diff-8294717bc9be9d276f548ae9f83e2831503589ef17d4d5bf6f1463cdb397d00eR104
samm:description "The ID of the initial issuer of the single level BoMAsSpecified"@en; | ||
samm:characteristic samm-c:Text; | ||
samm:exampleValue "BPNL1234567890LR". | ||
:assetIdTrait a samm-c:Trait; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for uuidv4, you can directly make use of shared aspect model. example: https://github.com/eclipse-tractusx/sldt-semantic-models/pull/405/files#diff-8294717bc9be9d276f548ae9f83e2831503589ef17d4d5bf6f1463cdb397d00eR45
and then you can delete your own Characteristic and Uuidv4RegularExpression
samm:dataType :ItemEntity. | ||
:ItemEntity a samm:Entity; | ||
samm:preferredName "Item Entity"@en; | ||
samm:description "Entity encapsulating the properies describing a item"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo properies
@LuisRickert Could you please check my comments. |
@LuisRickert any updates on this model? |
@LuisRickert is this model ready for MS2 check? |
Description
Closes #401
Questions to reviewer:
- alternative just change the Version 2.0.0MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)