Produce checksums for artifacts #326
-
Hello Tycho users! The next version of Eclipse (2021-12) is will log if p2 is missing checksums. For example we are seeing this new log entry:
I have found that our project (Eclipse EPP) does not, and never has, generated Is there a setting that forces checksums on or off? I have tried the fix-artifacts-metadata-mojo but that didn't add them (maybe it only corrects ones that are already present?). The issues in EPP is tracked by Bug 576528 |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 2 replies
-
Tycho generates checksums by default, what tycho version + mojo-configuration are you using to generate the update-sites? There is an extension point |
Beta Was this translation helpful? Give feedback.
-
Adding checksums usually comes from p2 publisher IIRC, I think it should be
investigated in p2 the ProductPublisher or the subparts that take care of
creating the "binary" artifacts.
It's definitely a good thing we start logging such missing checksums
errors, it unveils some existing flaws other approaches have failed at
noticing so far.
On Saturday, October 9, 2021, Christoph Läubrich ***@***.***> wrote:
Tycho generates checksums by default, what tycho version + mojo are you
using to generate the update-sites?
fix-artifacts-metadata should also update or add them, so maybe something
in the setup is preventing the calculation of checksums? Do you see any
errors/warning in the log?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android. <
…--
Mickael Istria
Eclipse IDE <https://www.eclipse.org/eclipseide> developer, for Red Hat
Developers <https://developers.redhat.com/>
|
Beta Was this translation helpful? Give feedback.
-
If the mirroring source is the "Tycho internal repo" there are no checksums to mirror. This was the case in EPP because Bug 518965 "create the p2 mirror from Tycho internal repo (so we can skip the assemble repo)." the checksums were lost in the final output as the Tyhco internal repo does not contain the checksums. There is probably an issue to be filed for Tycho in here, but not sure what it is yet (could be: "Tycho internal repos should contain checksum properties"?)
I don't think I ever ran this properly, there is very little feedback in this mojo, but I discovered that I was not running it on the correct directory. I raised #348 to help the next person. |
Beta Was this translation helpful? Give feedback.
If the mirroring source is the "Tycho internal repo" there are no checksums to mirror. This was the case in EPP because Bug 518965 "create the p2 mirror from Tycho internal repo (so we can skip the assemble repo)." the checksums were lost in the final output as the Tyhco internal repo does not contain the checksums.
There is probably an issue to be filed for Tycho in here, but not sure what it is yet (could be: "Tycho internal repos should contain checksum properties"?)
I don't think I ever ran this properly, …