Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependecy updates #1830

Closed
wants to merge 2 commits into from
Closed

Dependecy updates #1830

wants to merge 2 commits into from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 7, 2022

No description provided.

@laeubi
Copy link
Member Author

laeubi commented Dec 7, 2022

/request-license-review

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/3640348162

@laeubi
Copy link
Member Author

laeubi commented Dec 7, 2022

Still blocked by BND lib review, I have added a comment to maven/mavencentral/biz.aQute.bnd/biz.aQute.bndlib/6.4.0

@akurtakov
Copy link
Member

maybe exclude bnd for now and let it be handled via #1779

@laeubi
Copy link
Member Author

laeubi commented Dec 7, 2022

maybe exclude bnd for now and let it be handled via #1779

Yep probably that will be required...

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Test Results

171 files   - 171  171 suites   - 171   5h 19m 27s ⏱️ + 2h 57m 50s
289 tests  -   23    48 ✔️  - 259  5 💤 ±0  1 +1  235 🔥 +235 
289 runs   - 335    48 ✔️  - 565  5 💤  - 6  1 +1  235 🔥 +235 

For more details on these failures and errors, see this check.

Results for commit f304ac1. ± Comparison against base commit 64f3486.

This pull request removes 33 and adds 10 tests. Note that renamed tests count towards both.
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ testProductBuildForJava11
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ testProductBuildForJava17
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ testP2ResolutionWithLowerBREEThanRequiredBundle
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ testRepositoryAggregationForJava7
org.eclipse.tycho.test.iu.IUMetadataGenerationTest ‑ testIUWithArtifact
org.eclipse.tycho.test.iu.IUMetadataGenerationTest ‑ testIUWithoutArtifact
org.eclipse.tycho.test.p2Repository.BasicP2RepositoryIntegrationTest ‑ test347416CustomFinalName
org.eclipse.tycho.test.p2Repository.BasicP2RepositoryIntegrationTest ‑ test381377BundleInclusion
org.eclipse.tycho.test.p2Repository.BasicP2RepositoryIntegrationTest ‑ testDependencyList
org.eclipse.tycho.test.p2Repository.BasicP2RepositoryIntegrationTest ‑ testIncludeIUViaMatchQuery
…
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.iu.IUMetadataGenerationTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.BasicP2RepositoryIntegrationTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.RepoRefLocationP2RepositoryIntegrationTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.TransitiveP2RepoTest ‑ Unknown test
org.eclipse.tycho.test.product.ProductTypesTest ‑ Unknown test
org.eclipse.tycho.test.product.Tycho188P2EnabledRcpTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Dec 7, 2022

Failures probably because of https://issues.apache.org/jira/browse/MSHARED-1125 @akurtakov do you think its worth take a look or should I rollback? I'm not sure how much time I'll find to adjust the test as I'm a bit busy these days ...

@akurtakov
Copy link
Member

In general I have found that doing so many updates at once always fails so its better to go smaller

@laeubi
Copy link
Member Author

laeubi commented Dec 7, 2022

Problem is that the verifier update requires some more changes that can not be split... lets see if my fix works..

@laeubi
Copy link
Member Author

laeubi commented Dec 8, 2022

Lets see if this works better then: #1842

@laeubi laeubi closed this Dec 8, 2022
@laeubi laeubi added this to the 4.0 milestone Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants