Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for tycho-apitools-plugin:verify mojo #2281

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Mar 24, 2023

This adds an integration test for the tycho-apitools-plugin:verify mojo.

On my Windows computer this currently fails saying that the baseline must not be null.
Furthermore I currently have no good idea how encode the repository URL as a relative path. At the moment I use file:///${maven.multiModuleProjectDirectory}/repositories/api-tools, but that fails on Windows since it mixes forward and backward slashes. But it should succeed on Unix.
Besides that the test-case needs some assertions.

FYI @laeubi.

@github-actions
Copy link

github-actions bot commented Mar 24, 2023

Test Results

0 files   -    543  0 suites   - 543   0s ⏱️ - 4h 8m 39s
0 tests  -    339  0 ✔️  - 322  0 💤  - 10  0  - 5 
0 runs   - 1 017  0 ✔️  - 979  0 💤  - 31  0  - 5 

Results for commit bcf182e. ± Comparison against base commit 9c423ce.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Mar 24, 2023

Furthermore I currently have no good idea how encode the repository URL as a relative path

The usual approach in the Itest is to have a variable (e.g. ${baselineRepo}) in the pom, then set this in the verifier via

File repo = new File(verifier.getBaseDir(), "..some path...");
verifier.setCliArgument("-DbaselineRepo"+=repo.getAbsoloutePath())

@laeubi
Copy link
Member

laeubi commented Mar 24, 2023

@HannesWell this seem to break the generate test-case with:

.api_description not found

is a change in this area expected / intended? I currently can't see why this would interact here....

Co-authored-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@HannesWell
Copy link
Member Author

@HannesWell this seem to break the generate test-case with:

.api_description not found

is a change in this area expected / intended? I currently can't see why this would interact here....

No that was accidental. Thank you for fixing this in #2282.

Btw. if you want you can also push extra commits directly to my branch do avoid the need for an extra PR. :)

@laeubi laeubi marked this pull request as ready for review March 24, 2023 10:02
@laeubi laeubi merged commit 672552e into eclipse-tycho:master Mar 24, 2023
@HannesWell HannesWell deleted the apiToolsTest branch March 24, 2023 10:40
@laeubi laeubi added this to the 4.0 milestone Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants