Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security warnings #60

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix security warnings #60

merged 1 commit into from
Jan 31, 2024

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Jan 29, 2024

Fix dependabot security alerts

Copy link

File Coverage Lines Branches
All files 20% 26% 14%
desired_state_generator/src/gen_desired_state.py 36% 41% 32%
runtime_k3d/src/app_deployment/build_vehicleapp.py 0% 0% 0%
runtime_k3d/src/app_deployment/deploy_vehicleapp.py 0% 0% 0%
runtime_k3d/src/runtime/controlplane.py 0% 0% 0%
runtime_k3d/src/runtime/runtime-down.py 0% 0% 0%
runtime_k3d/src/runtime/runtime-up.py 0% 0% 0%
runtime_k3d/src/runtime/runtime.py 0% 0% 0%
runtime_k3d/src/runtime/deployment/gen_helm.py 29% 39% 19%
runtime_k3d/src/runtime/deployment/gen_podspec.py 44% 54% 35%
runtime_k3d/src/runtime/deployment/lib.py 93% 87% 100%
runtime_kanto/src/app_deployment/build_vehicleapp.py 0% 0% 0%
runtime_kanto/src/app_deployment/deploy_vehicleapp.py 0% 0% 0%
runtime_kanto/src/runtime/controlplane_kanto.py 0% 0% 0%
runtime_kanto/src/runtime/runtime.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_down.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_up.py 0% 0% 0%
runtime_local/src/local_lib.py 22% 22% 0%
runtime_local/src/run-dapr-sidecar.py 0% 0% 0%
runtime_local/src/run-vehicle-app.py 0% 0% 0%
runtime_local/src/run_service.py 30% 42% 18%
runtime_local/src/runtime-up.py 0% 0% 0%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against b32351a

@kse3hi kse3hi requested a review from MP91 January 29, 2024 12:31
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you do that in the template and copy the files?

@kse3hi
Copy link
Contributor Author

kse3hi commented Jan 29, 2024

@MP91 , yes. As I understood, it is the only way. Or do you have a better idea?

Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kse3hi kse3hi merged commit b3c3d22 into main Jan 31, 2024
8 checks passed
@kse3hi kse3hi deleted the fix/security branch January 31, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants