CompositeFuture.allOf, anyOf, joinOf with generics #3595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompositeFuture.all(List<Future>), CompositeFuture.any(List<Future>) and CompositeFuture.join(List<Future>) use the raw type of Future because the code generator for other languages doesn't support wildcard extensions. IDEs and other code checkers warn about the raw type because the compiler cannot do type checks. Jens Reimann (ctron) suggests to create allOf, anyOf and joinOf methods in eclipse-vertx#2058. This avoids a breaking change with the existing methods and allows not to generate the generic methods for other languages. Resolves eclipse-vertx#1994, resolves eclipse-vertx#2058. Signed-off-by: Julian Ladisch <eclipse.org-rtn@ladisch.de>
|
for the moment we cannot accept this as we would like this to avoid using |
|
Are there any other suggestion how the issue can be resolved? |
|
do your own wrapper in the meantime I think |
|
I spent time trying to have wildcard working in codegen but it did not work out easily, I'll try revisiting this again soon |
julianladisch
added a commit
to folio-org/okapi
that referenced
this pull request
Nov 4, 2020
Coordinate a List<Future<T extends Future <?>>>, provides all(List<T>), any(List<T>) and join(List<T>) that work like CompositeFuture#all(List), CompositeFuture#any(List) and CompositeFuture#join(List) but properly check the generic type <T extends Future<?>>. See eclipse-vertx/vert.x#3595 why Vert.x doesn't have this.
8 tasks
|
Rejected. Workaround: do your own wrapper. |
|
I think it could now accepted in vertx 4 because this method is not codegen
anymore.
…On Sat, Sep 11, 2021 at 8:43 AM julianladisch ***@***.***> wrote:
Rejected.
Workaround: do your own wrapper.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3595 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCXZXLKT4A476MTPLO3UBL3ABANCNFSM4SIPPMDQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompositeFuture.all(List), CompositeFuture.any(List) and
CompositeFuture.join(List) use the raw type of Future because
the code generator for other languages doesn't support wildcard extensions.
IDEs and other code checkers warn about the raw type because the compiler
cannot do type checks.
Jens Reimann (ctron) suggests to create allOf, anyOf and joinOf methods
in #2058. This avoids a breaking change with the existing methods and
allows not to generate the generic methods for other languages.
Resolves #1994, resolves #2058.