Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Oomph setup file to load content from Github #150

Open
ujhelyiz opened this issue Mar 20, 2024 · 6 comments
Open

Update Oomph setup file to load content from Github #150

ujhelyiz opened this issue Mar 20, 2024 · 6 comments
Assignees
Milestone

Comments

@ujhelyiz
Copy link
Contributor

The Oomph setup files got broken after the migration to Github (e.g. it sets up a wrong Git repository and changes are not anymore fetched by the central registry).

@ujhelyiz ujhelyiz added this to the 2.9.0 milestone Mar 20, 2024
@ujhelyiz ujhelyiz self-assigned this Mar 20, 2024
@bergmanngabor
Copy link
Contributor

FWIW I have run an Oomph setup today to see where we stand now.

Feedback:

  • I had to manually specify the Oomph parameter for the CI base address as https://ci.eclipse.org/viatra/job/VIATRA/job/master
    • ... and I have to supply it again and again every time I run Setup Tasks
  • RCPTT should be installed by Oomph - otherwise I am immediately prompted to do something about this unsupported project nature
  • A few build errors: (sample)
    • The project was not built since its build path is incomplete. Cannot find the class file for com.sun.jdi.StackFrame. Fix the build path then try building this project org.eclipse.viatra.query.tooling.debug Unknown Java Problem
    • An active annotation used in this file was compiled against a different version of Xtend than the one that is currently installed.
      • This one, unfortunately, seems to break vital parts of the query development UI

But the progress really looks promising, keep up the good work!

@ujhelyiz
Copy link
Contributor Author

ujhelyiz commented Apr 8, 2024

Most likely I will only continue to work on this after #152 will be merged, as the dependency changes will require another set of updates, and at that point will I plan finalize this. However, thanks for the feedback.

@bergmanngabor
Copy link
Contributor

the target platform was updated to SimRel 2020-06

Actually, it seems to be more like 2020-12. Corroborating this, I have found after bumping my Eclipse IDE to 2020-12 that the Xtend version inconsistency errors do indeed disappear (not the other problems).

@ujhelyiz
Copy link
Contributor Author

ujhelyiz commented Apr 8, 2024

the target platform was updated to SimRel 2020-06

Actually, it seems to be more like 2020-12. Corroborating this, I have found after bumping my Eclipse IDE to 2020-12 that the Xtend version inconsistency errors do indeed disappear (not the other problems).

The base target platform everything has to compile against is 2020-06; you can use Oomph to install VIATRA with the current platform, e.g. I am using it with 2024-03. It is possible I have messed up something with older versions, but I really don't plan to fix those before merging the new minimum dependency versions (that would change things greatly).

On the other hand, thinking about the issue you mentioned here I found that the VIATRA Tooling configuration was not correct. I don't usually use that configuration so issues might fall through the cracks here. I tried to update the given URL as necessary. @bergmanngabor Could you test whether this has fixed (at least some) of the issues?

@bergmanngabor
Copy link
Contributor

bergmanngabor commented Apr 8, 2024

Pulling the newest setup file and re-running the setup, I see P2 Director complaining:

Caused by: java.net.URISyntaxException: Illegal character in scheme name at index 0: https://ci.eclipse.org/viatra/job/VIATRA/job/master/lastSuccessfulBuild/artifact/releng/org.eclipse.viatra.update/target/repository

But there is no longer a missing Setup parameter, thankfully.

ujhelyiz added a commit that referenced this issue Apr 8, 2024
@ujhelyiz
Copy link
Contributor Author

ujhelyiz commented Apr 8, 2024

It was a copy-paste error, I have managed to add spaces to the XML... Sorry.

ujhelyiz added a commit that referenced this issue Apr 12, 2024
 * Cleans up code generation ordering
 * Adds RCPTT IDE to P2 Director task
 * Reorganizes dependencies
ujhelyiz added a commit that referenced this issue Apr 12, 2024
This is required as in case of modern target platform version MWE runs
on Java 17+
ujhelyiz added a commit that referenced this issue Apr 13, 2024
 - Filters out project import for
org.eclipse.viatra.query.patternlanguage.metamodel.queries.test that is
an incomplete, currently unused project
 - Adds missing code generator
 - Minor updates to mwe configurations
 - Minor fixes in the metamodel.validation project to avoid compile
errors
ujhelyiz added a commit that referenced this issue Apr 13, 2024
 - Removes unnecessary extra builds during the process
 - Remove extra redirect url
 - Finetune task ordering
ujhelyiz added a commit that referenced this issue Apr 13, 2024
 - Increases compliance to Java 11
 - Ensures that manifest and plugin.xml files are not touched by the
generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants