Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #145

Closed
eclipse-viatra-bot opened this issue Mar 12, 2024 · 0 comments
Closed

Update dependencies #145

eclipse-viatra-bot opened this issue Mar 12, 2024 · 0 comments
Assignees
Labels
bugzilla Issues migrated from Eclipse bugzilla. Common
Milestone

Comments

@eclipse-viatra-bot
Copy link

| --- | --- |
| Bugzilla Link | 582850 |
| Status | NEW |
| Importance | P3 normal |
| Reported | Jan 12, 2024 10:39 EDT |
| Modified | Jan 12, 2024 10:39 EDT |
| Version | 2.9.0 |
| Reporter | Zoltan Ujhelyi |

Description

Starting version 2.9 we should remove support for old dependencies, at the very least we should

  • Require Java 11
  • Update the latest platform version that works and builds with Java 11
  • Update the latest Xtext version that works and builds with Java 11
  • Update Tycho to current version

In addition to that, we should review the dependencies and build configurations to see whether we could simplify our current structure.

@eclipse-viatra-bot eclipse-viatra-bot added bugzilla Issues migrated from Eclipse bugzilla. Common legacy labels Mar 12, 2024
@ujhelyiz ujhelyiz added this to the 2.9.0 milestone Mar 19, 2024
@ujhelyiz ujhelyiz self-assigned this Mar 19, 2024
ujhelyiz added a commit that referenced this issue Mar 22, 2024
In addition to updating the Java requirements, the target platform was
updated to SimRel 2020-06 and additional dependency updates were done to
ensure everything still compiles as expected.

Detailed change list:

 * Java 11 requirement set up consistently in the projects
 * Updated Tycho to latest 4.0.4 version. This requires the Tycho job to
run on Java 17 (and requiring Maven 3.9+ to compile VIATRA core) and
rely on toolchains to compile for Java 11. This was necessary, as in our
current set of dependencies both the 2.7.5 and the 3.0.3 version of
Tycho had some basically unfixable problems related to test execution.
This also required to update some Tycho configurations to be updated
because between Tycho 1.7 and 4.0.4 there were some breaking changes.
 * Reviewed Guice dependencies, but as 2022-06 still contains Guice 3.0,
they were not updated in the plugin manifests (except some removals
where they were unnecessary)
 * Added javax.annotations to the package imports of query projects.
This is necessary for the generator to be able to add the @generated
annotations to the code (this was previously part of the JDK). The new
project creation and project update functionality was also updated to
always require this package in the future.
 * Updated Xtext to latest (2.33) version as a minimum
 * Updated RCPTT to latest  (2.5.4) version for tests
 * Updated required Maven version to 3.8.1 to follow security
requirements by Dependabot
https://github.com/eclipse-viatra/org.eclipse.viatra/security/dependabot/1
 * Adapted Maven dependencies to represent current usage
 * Updated RCPTT tests to match changes in platform (rename of the New
wizard window) and the addition of the extra dependency to query
projects

Signed-off-by: Zoltán Ujhelyi <zoltan.ujhelyi@incquerylabs.com>
ujhelyiz added a commit that referenced this issue Mar 22, 2024
ujhelyiz added a commit that referenced this issue Mar 22, 2024
Hopefully this will solve the build issue on Jenkins related to not
being able to get dependencies for this old version.
@ujhelyiz ujhelyiz removed the legacy label Mar 25, 2024
ujhelyiz added a commit that referenced this issue Mar 26, 2024
Hopefully this will reduce the number of false execution errors in
Jenkins seen with #145
ujhelyiz added a commit that referenced this issue Mar 26, 2024
 - Use updated asciidoctor parameterization
 - Removed unnecessary exclude rules from help plugin
 - Minor enhancements to the help plugin
 - Updates jacoco and cbi jarsigner versions
 - Removes unnecessary resolver configuration from target platform
 - Removes unnecessary goals from Xtend compiler configuration
ujhelyiz added a commit that referenced this issue Mar 27, 2024
Removes redundant configuration of macOS-specific start on first thread
feature; updated the way vm arguments are set to the application under
test. Furthermore, hoping the <vm> parameter will ensure that the
application under test will start on a toolchain-aware Java 11 instance
(on the server it starts with Java 17).

The hope is that by reducing the maximum amount of memory used by the
RCPTT build, it becomes less often that the build environment runs out
of memory (that might be the possible cause of random test failures).
ujhelyiz added a commit that referenced this issue Mar 27, 2024
This change introduces another attempt to fix the intermittent test
issues on Jenkins
ujhelyiz added a commit that referenced this issue Mar 28, 2024
Another experiment to make sure the test runs correctly on Jenkins.
ujhelyiz added a commit that referenced this issue Apr 12, 2024
ujhelyiz added a commit that referenced this issue Apr 13, 2024
 - Increases compliance to Java 11
 - Ensures that manifest and plugin.xml files are not touched by the
generator
ujhelyiz added a commit that referenced this issue Jun 25, 2024
SimRel 2022-06 contains Eclipse Collections version 11.1.0, so updating
the minimum dependency to this makes the range consistent with the
current releases.

In case of the MANIFEST.MF entry in the matchers project version 11.0.0
is used as a dependency, as the manifest version was not updated
correctly for release 11.1.0.

Signed-off-by: Zoltán Ujhelyi <zoltan.ujhelyi@incquerylabs.com>
ujhelyiz added a commit that referenced this issue Jun 26, 2024
SimRel 2022-06 contains Eclipse Collections version 11.1.0, so updating
the minimum dependency to this makes the range consistent with the
current releases.

In case of the MANIFEST.MF entry in the matchers project version 11.0.0
is used as a dependency, as the manifest version was not updated
correctly for release 11.1.0.

Signed-off-by: Zoltán Ujhelyi <zoltan.ujhelyi@incquerylabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from Eclipse bugzilla. Common
Projects
None yet
Development

No branches or pull requests

2 participants