Fix for issue #185 and #187

[scheind]

Sorry for not creating the PR sooner. Kinda lost track of it

[eriawan]

@scheind
Please fulfill the Eclipse ECA agreement first. Thanks in advance!

[mickaelistria]

Can you please sign the Eclipse contributor agreement https://accounts.eclipse.org/user/login?destination=legal/eca/validation/129563 ?

[scheind]

So I created a account at eclipse and signed the ECA but it still says that it could not validate the sign-off status. Do I have to do something additionally?

[eriawan]

@scheind

Could you please check the email address is matched with the email you register for Eclipse?

[scheind]

@eriawan Yes seems to be the same

[eriawan]

@scheind
Apologize I couldn't help you further. Maybe @mickaelistria could provide additional help?

[mickaelistria]

I do not see any obvious reason why this would fail; the email address mismatch between the commit author and the Eclipse account is indeed the usual suspect, but if this is not the cause here, I don't know what else to suggest. Maybe @waynebeaton can tell more...

[akurtakov]

Would you also please rebase on top of master where build should be fixed and your changes should hopefully fix the failing tests.

[akurtakov]

I've tried this patch on top of master with dotnet 6 and new wizard still doesn't have templates.

[waynebeaton]

Whatever was the problem, it appears to have been fixed (note that if you follow the "Details" link, you can rerun the validation).

As a matter of practice, open an issue against the Eclipse Foundation help desk when you encounter these sorts of problems. The IT team are the ones who maintain this infrastructure and we really need them to diagnose these sorts of issues if we have any hope of improving it.

[scheind]

@akurtakov Was this in the tests? I synced the repository and tried it again on my end. I used dotnet 6 and 7 (although not really different) and the templates where displayed.

[akurtakov]

no, I cherry-picked your commit on master locally and tried it. I'll have to look further.
Btw, please git rebase on top of master so my commits and your merge commit are gone.

[scheind]

Sorry for the many comments. This is really my first time with git rebase so I'm not to sure. What exactly do I have to do?

[akurtakov]

Assuming you have this repo as "upstream" remote (added via git remote add upstream https://github.com/eclipse/aCute) you should be able to do git rebase upstream/master.
Due to the merge commit you may have to do some extra work though:

• git reset --hard upstream/master
• git cherry-pick 3a29fee

[scheind]

I assume it should look something like this then:

And after that a simple push correct?

[akurtakov]

Not familiar with the tool used . Just push it :)

[scheind]

ok pushed it and it says "everything up-to-date"

[eriawan]

@scheind could you fix the test failures?

[scheind]

@eriawan The test failures in Jenkins seem to be related to another issue since it couldn't find the menu bar for the shell.

But I don't know enough about SWTBotTest or how it works.

[eriawan]

@scheind
OK, we could fix that later. I have tested this, and it's surely LGTM.
Thanks for the contribution!

Currently next week I'm going to focus on my own daily works on some on .NET Core, including some works on NET 7.0 too. Then have a long vacation starting from mid December.
I'm going to approve this, but please ensure that you have some screenshots and captures that this PR works, then I'll try to merge this before mid December.

[eriawan]

LGTM for now!

[eriawan]

To other collaborators, feel free to chime in. 🙂

[scheind]

Thanks and sorry I couldn't be of more help with the tests.
Here are the screenshots from my system:

Tried it with dotnet version 6 and 7:

Result when running the plugin and creating a new project:

[eriawan]

Thanks and sorry I couldn't be of more help with the tests. Here are the screenshots from my system:

Tried it with dotnet version 6 and 7:

Result when running the plugin and creating a new project:

Thanks for the screenshots! Yes, I also have tested this myself. ✔️
I'm going to merge this now.

Again, thanks for the contribution! 👍

[scheind]

Yes no problem, despite being a little late (3 months or so 😄 )
And hope you have a great vacation in december 👍