Che operator should be able to install DevWorkspace operator #689

tolusha · 2021-02-24T13:38:41Z

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Deploys Dev Workpace operator if spec.devWorkspace.enable: true

Screenshot/screencast of this PR

time="2021-03-01T12:37:49Z" level=info msg="Creating a new object: Namespace, name devworkspace-controller"
time="2021-03-01T12:37:49Z" level=info msg="Creating a new object: ServiceAccount, name devworkspace-controller-serviceaccount"
time="2021-03-01T12:37:49Z" level=info msg="Creating a new object: ClusterRole, name devworkspace-controller-role"
time="2021-03-01T12:37:49Z" level=info msg="Creating a new object: ClusterRole, name devworkspace-controller-proxy-role"
time="2021-03-01T12:37:49Z" level=info msg="Creating a new object: ClusterRole, name devworkspace-controller-edit-workspaces"
time="2021-03-01T12:37:49Z" level=info msg="Creating a new object: ClusterRole, name devworkspace-controller-view-workspaces"
time="2021-03-01T12:37:50Z" level=info msg="Creating a new object: Role, name devworkspace-controller-leader-election-role"
time="2021-03-01T12:37:50Z" level=info msg="Creating a new object: RoleBinding, name devworkspace-controller-leader-election-rolebinding"
time="2021-03-01T12:37:51Z" level=info msg="Creating a new object: ClusterRoleBinding, name devworkspace-controller-rolebinding"
time="2021-03-01T12:37:52Z" level=info msg="Creating a new object: ClusterRoleBinding, name devworkspace-controller-proxy-rolebinding"
time="2021-03-01T12:37:55Z" level=info msg="Creating a new object: CustomResourceDefinition, name devworkspaces.workspace.devfile.io"
time="2021-03-01T12:38:01Z" level=info msg="Creating a new object: CustomResourceDefinition, name components.controller.devfile.io"
time="2021-03-01T12:38:11Z" level=info msg="Creating a new object: CustomResourceDefinition, name devworkspacetemplates.workspace.devfile.io"
time="2021-03-01T12:38:32Z" level=info msg="Creating a new object: CustomResourceDefinition, name workspaceroutings.controller.devfile.io"
time="2021-03-01T12:39:13Z" level=info msg="Creating a new object: ConfigMap, name devworkspace-controller-configmap"
time="2021-03-01T12:40:36Z" level=info msg="Creating a new object: Deployment, name devworkspace-controller-manager"

What issues does this PR fix or reference?

eclipse-che/che#19121

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

openshift-ci-robot · 2021-02-24T13:38:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2021-02-24T13:40:05Z

Codecov Report

Merging #689 (8c5d8e9) into master (80e33df) will increase coverage by 1.03%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   31.60%   32.64%   +1.03%     
==========================================
  Files          49       50       +1     
  Lines        5369     5459      +90     
==========================================
+ Hits         1697     1782      +85     
+ Misses       3421     3409      -12     
- Partials      251      268      +17

Impacted Files	Coverage Δ
pkg/deploy/kubernetes_image_puller.go	`0.00% <ø> (ø)`
pkg/util/util.go	`9.95% <0.00%> (-0.36%)`	⬇️
pkg/controller/che/che_controller.go	`19.30% <11.11%> (-0.11%)`	⬇️
pkg/deploy/sync.go	`46.25% <44.44%> (+46.25%)`	⬆️
pkg/deploy/dev-workspace/dev_workspace.go	`74.60% <74.60%> (ø)`
pkg/deploy/defaults.go	`46.80% <100.00%> (+0.28%)`	⬆️
pkg/deploy/server/che_configmap.go	`82.05% <100.00%> (+0.09%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e33df...8c5d8e9. Read the comment docs.

sleshchenko · 2021-03-01T08:05:03Z

Dockerfile

 RUN export ARCH="$(uname -m)" && if [[ ${ARCH} == "x86_64" ]]; then export ARCH="amd64"; elif [[ ${ARCH} == "aarch64" ]]; then export ARCH="arm64"; fi && \
    export MOCK_API=true && \
    go test -mod=vendor -v ./... && \
    GOOS=linux GOARCH=${ARCH} CGO_ENABLED=0 go build -mod=vendor -o /tmp/che-operator/che-operator cmd/manager/main.go

+# download devworkspace-operator templates
+RUN curl -L https://api.github.com/repos/devfile/devworkspace-operator/zipball/master > /tmp/devworkspace-operator.zip && \


I think devworkspace operator version should be defined as argument.

Right now there are only master and v1.0.0-alpha1
I can define env variable in the Dockerfile.

it's just because release lack. But soon releases will be with Che cadence.
If you meant argument, that +1
If you meant environment variable - please elaborate more

ENV DEV_WORKSPACE_CONTROLLER_VERSION="master"
When che-operator is released the correct version will be set

Why it's env var but not argument? Like here https://github.com/eclipse/che/blob/master/dockerfiles/che/Dockerfile#L11

ok. make sense

local-debug.sh

pkg/deploy/dev-workspace/dev_workspace.go

pkg/deploy/sync_test.go

pkg/deploy/namespace.go

tolusha · 2021-03-04T13:35:11Z

/retest

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

flacatus · 2021-03-04T17:27:38Z

/retest

openshift-ci-robot · 2021-03-04T18:50:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Che operator should be able to install DevWorkspace operator Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fix typo Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Add missing roles Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update cluster roles Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update nightly bundle Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fixes Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Add missing files Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fixes Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fix tests Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Add tests Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update nightly bundle Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Improvements Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Add logs Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fix test Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fix tests Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update nightly bundle Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update clusterroles Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update test Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update test Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update nightly bundle Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Che operator should be able to install DevWorkspace operator (#689) * Che Operator should be able to install the Devworkspace che operator (#707) Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Sergii Kabashniuk <skabashn@redhat.com> Co-authored-by: Lukas Krejci <lkrejci@redhat.com> Co-authored-by: Anatolii Bazko <abazko@redhat.com>

openshift-ci-robot added the do-not-merge/work-in-progress label Feb 24, 2021

tolusha mentioned this pull request Feb 24, 2021

Che Deploy Sprint #197 eclipse-che/che#18992

Closed

57 tasks

tolusha mentioned this pull request Feb 25, 2021

Che Deploy Sprint #198 eclipse-che/che#19155

Closed

70 tasks

sleshchenko reviewed Mar 1, 2021

View reviewed changes

metlos mentioned this pull request Mar 2, 2021

Che Operator should be able to install the Devworkspace che operator eclipse-che/che#19142

Closed

tolusha force-pushed the che-19121 branch from 38a4e07 to ce3f48e Compare March 3, 2021 09:00

tolusha marked this pull request as ready for review March 3, 2021 09:48

tolusha requested review from AndrienkoAleksandr, flacatus, mmorhun and nickboldt as code owners March 3, 2021 09:48

openshift-ci-robot removed the do-not-merge/work-in-progress label Mar 3, 2021

AndrienkoAleksandr reviewed Mar 3, 2021

View reviewed changes

local-debug.sh Outdated Show resolved Hide resolved

AndrienkoAleksandr reviewed Mar 3, 2021

View reviewed changes

pkg/deploy/dev-workspace/dev_workspace.go Show resolved Hide resolved

AndrienkoAleksandr reviewed Mar 3, 2021

View reviewed changes

pkg/deploy/sync_test.go Outdated Show resolved Hide resolved

AndrienkoAleksandr reviewed Mar 3, 2021

View reviewed changes

pkg/deploy/namespace.go Outdated Show resolved Hide resolved

openshift-ci-robot added the needs-rebase label Mar 4, 2021

tolusha force-pushed the che-19121 branch from 4b802f1 to 85b98fe Compare March 4, 2021 13:52

openshift-ci-robot removed the needs-rebase label Mar 4, 2021

tolusha added 8 commits March 4, 2021 18:25

Che operator should be able to install DevWorkspace operator

b7d03b4

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Fix typo

c81a3af

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Add missing roles

d7c648e

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update cluster roles

905321b

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update nightly bundle

282ee55

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Fixes

be64dcb

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Add missing files

8a60892

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Fixes

0b7b081

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

tolusha added 12 commits March 4, 2021 18:25

Fix tests

a7d4384

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Add tests

b379296

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update nightly bundle

75a5b2f

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Improvements

3ec087d

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Add logs

0a9c90b

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Fix test

0b91565

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Fix tests

f75b3b2

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update nightly bundle

4df7db3

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update clusterroles

5995458

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update test

f8bf11e

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update test

867db24

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Update nightly bundle

8c5d8e9

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

tolusha force-pushed the che-19121 branch from cba408b to 8c5d8e9 Compare March 4, 2021 16:28

AndrienkoAleksandr approved these changes Mar 4, 2021

View reviewed changes

openshift-ci-robot assigned AndrienkoAleksandr Mar 4, 2021

openshift-ci-robot added the lgtm label Mar 4, 2021

tolusha merged commit 052a637 into master Mar 4, 2021

tolusha deleted the che-19121 branch March 4, 2021 19:59

che-bot added this to the 7.27 milestone Mar 4, 2021

tolusha mentioned this pull request Mar 5, 2021

chore(yarn.lock): Update dependencies che-incubator/chectl#1125

Merged

9 tasks

l0rd mentioned this pull request Mar 5, 2021

Release Che 7.27.1 eclipse-che/che#19221

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Che operator should be able to install DevWorkspace operator #689

Che operator should be able to install DevWorkspace operator #689

tolusha commented Feb 24, 2021 •

edited

openshift-ci-robot commented Feb 24, 2021

codecov bot commented Feb 24, 2021 •

edited

sleshchenko Mar 1, 2021

tolusha Mar 1, 2021

sleshchenko Mar 1, 2021 •

edited

tolusha Mar 4, 2021

sleshchenko Mar 4, 2021

tolusha Mar 4, 2021

tolusha commented Mar 4, 2021

flacatus commented Mar 4, 2021

openshift-ci-robot commented Mar 4, 2021

Che operator should be able to install DevWorkspace operator #689

Che operator should be able to install DevWorkspace operator #689

Conversation

tolusha commented Feb 24, 2021 • edited

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

PR Checklist

Reviewers

openshift-ci-robot commented Feb 24, 2021

codecov bot commented Feb 24, 2021 • edited

Codecov Report

sleshchenko Mar 1, 2021

Choose a reason for hiding this comment

tolusha Mar 1, 2021

Choose a reason for hiding this comment

sleshchenko Mar 1, 2021 • edited

Choose a reason for hiding this comment

tolusha Mar 4, 2021

Choose a reason for hiding this comment

sleshchenko Mar 4, 2021

Choose a reason for hiding this comment

tolusha Mar 4, 2021

Choose a reason for hiding this comment

tolusha commented Mar 4, 2021

flacatus commented Mar 4, 2021

openshift-ci-robot commented Mar 4, 2021

tolusha commented Feb 24, 2021 •

edited

codecov bot commented Feb 24, 2021 •

edited

sleshchenko Mar 1, 2021 •

edited