Update License to EPL-2.0 and fixing build #9
Conversation
sunix
commented
Aug 28, 2018
•
sunix
commented
- EPL 2.0: Upgrade project license from EPL-1.0 to EPL-2.0 eclipse-che/che#10465
- Fixing build: none of the branches are compiling for che-theia-hosted-plugin-manager-extension eclipse-che/che#10810
- adding tslint config and apply suggestions
eclipse-che/che#10465 Signed-off-by: Sun Tan <sutan@redhat.com>
browser-app/package.json
Outdated
| "@theia/terminal": "0.3.12", | ||
| "@theia/typescript": "0.3.12", | ||
| "@theia/workspace": "0.3.12", | ||
| "@theia/core": "~0.3.13", |
There was a problem hiding this comment.
I prefer to have fixed version on Theia dependencies
There was a problem hiding this comment.
Please give your reasons.
I don't think there is any problem in using latest 0.3.x version and we will have feedback from CI sooner, get errors sooner and fix them sooner. Also the way we add the extensions to the Theia image won't use this version of theia.
There was a problem hiding this comment.
AFAIK it's mainly due to CQs (waiting Theia becoming Eclipse project)
che-theia-factory/package.json
Outdated
| "rimraf": "2.6.2", | ||
| "typescript": "2.7.2" | ||
| "rimraf": "^2.6.2", | ||
| "typescript": "^2.9.2" |
There was a problem hiding this comment.
we can't use ^ as we need CQ for each dependency
There was a problem hiding this comment.
OK thanks ... but how do we do with all the dependencies that comes with Theia ?
There was a problem hiding this comment.
@evidolob I think you told me that this is devDependencies and we have v+above CQ for it? Am I right?
There was a problem hiding this comment.
Unfortunately we have CQ only for rimraf 2.6.2, for TypeScript CQ still not approved
There was a problem hiding this comment.
I can remove the carets ^. Will it be fine to merge then ? or do we need to wait for CQ approval ?
There was a problem hiding this comment.
I will ping PMC for TypeScript, should be quick to approve
…ion of typescript Signed-off-by: Sun Tan <sutan@redhat.com>
Signed-off-by: Sun Tan <sutan@redhat.com>
Signed-off-by: Sun Tan <sutan@redhat.com>
|
@benoitf @evidolob CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16945 has been approved |
|
yes I ping Sharon yesterday for CQ |
