Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go test and go build #10328

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Conversation

InnovativeInventor
Copy link
Contributor

What does this PR do?

It adds a test and build command to the default go stack (see #10168)

What issues does this PR fix or reference?

None, its an enhancement

Release Notes

Added a test and build command to the default go stack

@codenvy-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jul 8, 2018
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@skabashnyuk
Copy link
Contributor

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10328
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor

@eclipse/eclipse-che-qa can you take a look on a report? is it good or bad?

@SkorikSergey
Copy link
Contributor

SkorikSergey commented Jul 10, 2018

@InnovativeInventor you need to add a comma at the end of lines 734 and 743. Without them the stacks.json file is not valid.

@skabashnyuk
Copy link
Contributor

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10328
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vkuznyetsov vkuznyetsov mentioned this pull request Jul 17, 2018
39 tasks
@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/481/) doesn't show any regression against this Pull Request.

@skabashnyuk skabashnyuk merged commit c24a9e2 into eclipse-che:master Jul 17, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 17, 2018
@benoitf benoitf added this to the 6.9.0 milestone Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants