Also copy the content of the truststore config map to the workspace namespace (port from 7.20.x) #18280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amespace (#18264) * Allow copying also the content of the config map * Use the `CheServerKubernetesClientFactory` to have the permission to read the config map from the Che server namespace * Move constructor parameters as requested by @mshaposhnik * Additional change requested by @mshaposhnik Signed-off-by: David Festal <dfestal@redhat.com>
mshaposhnik
requested review from
amisevsk,
metlos,
nickboldt and
sleshchenko
as code owners
che-bot
added
the
status/code-review
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
skabashnyuk
approved these changes
Nov 5, 2020
sparkoo
approved these changes
Nov 5, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows correctly propagating up to the workspace, the content of the trusted CA bundle configured
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.