Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept of Minimal and Full assembly #4578

Merged
merged 17 commits into from
Apr 14, 2017
Merged

Concept of Minimal and Full assembly #4578

merged 17 commits into from
Apr 14, 2017

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Mar 27, 2017

What does this PR do?

The main goal of this issue is to introduce two maven modules for ws-agent minimum set of components that need to start workspace agent. che-ide-core is core ide part, che-wsagent-core is core server side part of workspace agent.

How to use them
We will use them in two ways:

  • As a fundament of our full assembly.
  • As a fundament for our samples.

Full assembly of IDE
To make Full assembly of ide we need to declare in assembly/assembly-ide-war/pom.xml

  1. IDE Core
        <dependency>
            <groupId>org.eclipse.che.core</groupId>
            <artifactId>che-ide-core</artifactId>
        </dependency>
  1. All IDE plugins we have in Che.
     <dependency>
            <groupId>org.eclipse.che.plugin</groupId>
            <artifactId>*</artifactId>
        </dependency>

Custom assembly of IDE based on minimal Che IDE
To make Custom assembly of IDE based on minimal Che IDE* we need to declare in assembly/assembly-ide-war/pom.xml

  1. IDE Core
        <dependency>
            <groupId>org.eclipse.che.core</groupId>
            <artifactId>che-ide-core</artifactId>
        </dependency>
  1. IDE part of custom plugin.
        <dependency>
            <groupId>my.plugin</groupId>
            <artifactId>plugin-json-ide</artifactId>
        </dependency>
  1. IDE war that will be reused to get some resources
       </dependency>
        <dependency>
            <groupId>org.eclipse.che</groupId>
            <artifactId>assembly-ide-war</artifactId>
            <type>war</type>
            <scope>runtime</scope>
        </dependency>

Full assembly of Ws-agent server war

  1. Core Ws agent war
    <dependency>
            <groupId>org.eclipse.che.core</groupId>
            <artifactId>che-wsagent-core</artifactId>
            <type>war</type>
        </dependency>
  1. Swagger support
        <dependency>
            <groupId>org.eclipse.che.lib</groupId>
            <artifactId>che-swagger-module</artifactId>
        </dependency>

3.All ws-agent plugins

       <dependency>
            <groupId>org.eclipse.che.plugin</groupId>
            <artifactId>che-plugin-*</artifactId>
        </dependency>

Custom assembly of ws-agent base minimal Che ws-agent

  1. Core Ws agent war
    <dependency>
            <groupId>org.eclipse.che.core</groupId>
            <artifactId>che-wsagent-core</artifactId>
            <type>war</type>
        </dependency>
  1. Plugin server side
        <dependency>
            <groupId>my.plugin</groupId>
            <artifactId>plugin-json-server</artifactId>
        </dependency>

** A couple of stats based on plugin-json**

Value Basic Full
ws-agent war size 17Mb 34 MB
GWT compilation 4min 6min
gwt scripts size 4,5 Mb 7.7 Mb
ide war size 6,3Mb 8Mb

What issues does this PR fix or reference?

#4403

Changelog

Introduced two maven modules for ws-agent minimum set of components that need to start workspace agent

Release Notes

Docs PR

eclipse-che/che-docs#202

@skabashnyuk skabashnyuk changed the title WP Che4403 WP Concept of Basic and Full assembly Mar 27, 2017
@skabashnyuk skabashnyuk force-pushed the che4403 branch 3 times, most recently from 925a346 to 54efdc2 Compare April 5, 2017 07:57
@codenvy-ci
Copy link

@skabashnyuk skabashnyuk added this to the 5.8.0 milestone Apr 7, 2017
@skabashnyuk skabashnyuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 7, 2017
@skabashnyuk skabashnyuk changed the title WP Concept of Basic and Full assembly Concept of Basic and Full assembly Apr 7, 2017
@bmicklea bmicklea changed the title Concept of Basic and Full assembly Concept of Minimal and Full assembly Apr 7, 2017
@skabashnyuk
Copy link
Contributor Author

@bmicklea if question to me - then I don't know. @TylerJewell @JamesDrummond has better understanding of docs structure. If it helps I can create separate page with content similar to the description of this issue. Just let me know what's needed.

@JamesDrummond
Copy link
Contributor

@bmicklea This should have docs I would think. I don't have a lot of time to do it before 5.8.0 release I think. Could we merge PR and them follow up with docs later?

@bmicklea
Copy link

bmicklea commented Apr 7, 2017

@skabashnyuk - please include an .md file and we will figure out where to put it.

@skabashnyuk
Copy link
Contributor Author

@bmicklea @JamesDrummond plz take a look eclipse-che/che-docs#198

@codenvy-ci
Copy link

@codenvy-ci
Copy link

@riuvshin riuvshin modified the milestones: 5.8.0, 5.9.0 Apr 11, 2017
@codenvy-ci
Copy link

@skabashnyuk
Copy link
Contributor Author

@bmicklea @JamesDrummond in this pr eclipse-che/che-archetypes#44 plugin-json-archetype will be based on minimal assembly.

@skabashnyuk
Copy link
Contributor Author

More stats

ws-agent startup time

Linux I7 3.40GHz SSD
Basic ws-agent start time 10 sec, tomcat start time 5-6 sec
Full ws-agent start time 15 sec, tomcat start time 8-9 sec

OSX I5 2.7GHz SSD
Basic ws-agent start time 23 sec, tomcat start time 10-12 sec
Full ws-agent start time 34 sec, tomcat start time 24 sec

@codenvy-ci
Copy link

@skabashnyuk skabashnyuk merged commit a6a569b into master Apr 14, 2017
@skabashnyuk skabashnyuk deleted the che4403 branch April 14, 2017 07:05
@codenvy-ci
Copy link

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Concept of Minimal and Full assembly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants