Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-5154: use another implementation of the Language Server Protocol for python #5267

Merged
merged 3 commits into from
Jun 7, 2017

Conversation

svor
Copy link
Contributor

@svor svor commented Jun 2, 2017

What does this PR do?

Changes an implementation of the LSP for python and adopts plugin-languageserver for using this one. The new implementation is from https://github.com/palantir/python-language-server.

New Features:

  1. Error/warning markers and messages
    f5
  2. Auto Completition
    f1
  3. Find References
    f4
  4. Find Definition
    f3
  5. Hover
    f2

What issues does this PR fix or reference?

#5154
#4976

Changelog

Change an implementation of the LSP for python

Release Notes

We have updated the LS used for Python by the Palayton one. This new Python LS is providing a better support and analyzis of the language which allows:

  1. Error/warning markers and messages
  2. Auto Completion
  3. Find References
  4. Find Definition
  5. Hover

Docs PR

@svor svor added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 2, 2017
@svor svor added this to the 5.12.0 milestone Jun 2, 2017
@svor svor self-assigned this Jun 2, 2017
@svor
Copy link
Contributor Author

svor commented Jun 2, 2017

@tolusha Need to replace binaries with New Binary

@codenvy-ci
Copy link

@codenvy-ci
Copy link

@svor svor merged commit 6a4e383 into master Jun 7, 2017
@svor svor deleted the CHE-5154 branch June 7, 2017 10:07
@slemeur
Copy link
Contributor

slemeur commented Jun 7, 2017

@svor : Could you please describe in the PR description the various benefits of having this new LS for python?

@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 7, 2017
@svor
Copy link
Contributor Author

svor commented Jun 8, 2017

@slemeur I've updated

@slemeur
Copy link
Contributor

slemeur commented Jun 9, 2017

Thanks @svor. it is perfect.

@philipp-lein
Copy link

First ... Thanks man I' ve waiting for this feature so long and I was not able to make it work.
Well Done, I'm really happy!
I need the new python features for a presentation next week.
I've pulled the master branch and build ls-python-agent and ws-agent-war and and and...
Maybe I've forgotten a build dependency or can't it work because the binaries (https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.python.binaries) not updated at the moment?
bildschirmfoto 2017-06-10 um 11 01 21

Thanks a lot

@tolusha
Copy link
Contributor

tolusha commented Jun 12, 2017

@phill1234
Binaries will be updated as soon as release is done.

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants